-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable conventional commits & Gitmoji 🚀 as configuration options #160
Conversation
Closes #32 |
afd30a0
to
b7f4e8c
Compare
How does one test this GitHub PR with the set conventional commits since there are not flags set? |
I don’t know what you mean, could you explain this in bit more detail? I tested this through the specs and it seems to add almost always the right conventional commit type. I do think that there needs to be an option to override the type whenever a user simply wants a specific one, but lets add that in a different PR? |
…ource code, paving the way for adding Gitmoji in a similar way.
Will do. After switching to this GitHub PR, I ran some tests locally using the following commands. However, I did not obtain the expected conventional commit output. This prompted me to consider the possibility of requiring some configuration.
|
I am planning to submit a GitHub PR. In the near future, I would like to see the An example is shown below in the following issue comment. |
I will check if I can include it in this PR, also adding more testing and refining the prompt. |
Understood, thank you. Currently I am running tests myself. |
@NorkzYT I greatly improved the tests, I also made the conventional commits more context aware and added Gitmoji to the mix. |
I can't set config using this approach. would you recommend adding gitmoji and conventional as cli flags?
|
Nice mate, great work! Now I need to make an issue since the Related issue: Related GitHub PR: |
I will see what I can do. |
@thijslimmen Earlier I read your question incorrectly. Yes, it would be beneficial for future use cases to have both conventional commits and gitmojis to have cli flags. |
Also, with the increasing amount of features, usability becomes a thing, because sometimes someone finds the text correct, but then the conventional commit type or gitmoji may not be right, so it would be nice to mix and match all the generated features. |
Agreed. |
Opened a PR with new changes. |
Add configuration to enable conventional commits. By default it is "false" to not break existing behavior. In the future this could be defaulted to "true", if that is a global standard.