-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visible tabs #266
base: v3.0
Are you sure you want to change the base?
Fix visible tabs #266
Conversation
Can we also put that magic number 21 to the top of that file (or somewhere else), then use it? |
of course, I created a local constant BUF_WIDTH, which I use in both places |
the total length of a tab was 23 before, why 21? |
😨 |
why are we closing this @romanschulz You can change it back |
I tried to determine the exact width of the panel for the buffer, because I think it is little bit smaller than the mentioned 23 characters, I just don't know if it is always... sometimes I counted 21 and now I saw that it can be 22 characters. When I think about it, it is the sum of: space + icon + space + 15 characters of the filename (or 16?) + space + X button + space = 21 (or 22) |
@romanschulz pr looks right, just lowecase the variable |
8b670b9
to
5be808e
Compare
Now all the space is not used enough. The total length of one tab is 21 characters, therefore it is necessary to adjust the calculation of which tabs can be displayed and which ones cannot. Also modify the padding calculation for a tab length of 21 characters.