Merge pull request #26 from 0x0I/min_ansible_version

update supported Ansible minimum version and apply refactorizations

handlers/main.yml

@@ -14,6 +14,7 @@
     state: stopped
     enabled: false
   listen: Uninstall service
+  ignore_errors: true
 
 - name: Remove Lotus systemd service file
   become: true
@@ -29,6 +30,7 @@
     state: stopped
     enabled: false
   listen: Uninstall service
+  ignore_errors: true
 
 - name: Remove Lotus storage miner systemd service file
   become: true

kitchen.yml

@@ -23,12 +23,14 @@ transport:
 provisioner:
   hosts: test-kitchen
   name: ansible_playbook
-  require_chef_for_busser: false
-  require_ruby_for_busser: false
+  require_pip: true
+  ansible_version: 2.9.4
   ansible_verbose: true
   ansible_cfg_path: test/ansible.cfg
   requirements_path: test/requirements-test.yml
   idempotency_test: true
+  require_chef_for_busser: false
+  require_ruby_for_busser: false
 
 verifier:
   name: inspec
@@ -46,17 +48,13 @@ platforms:
         - sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
         - systemctl enable sshd.service
         - yum -y install python-pip
-    provisioner:
-      require_pip: true
   - name: fedora-31
     driver_config:
       <<: *default_driver_config
       provision_command:
         - sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
         - systemctl enable sshd.service
         - yum -y install python-pip
-    provisioner:
-      require_pip: true
   - name: ubuntu-18.04
     driver_config:
       <<: *default_driver_config

tasks/common/install/archive_install.yml

@@ -5,7 +5,7 @@
   get_url:
     url: "{{ archive_url }}"
     dest: "/tmp/{{ archive_url | urlsplit('path') | basename }}"
-    checksum: "{{ checksum_format }}:{{ archive_checksum }}"
+    checksum: "{{ (archive_checksum|length > 0) | ternary(checksum_format+':'+archive_checksum, '') }}"
     mode: '0775'
   register: archive_tmp
   tags:

tasks/common/preflight.yml

@@ -16,10 +16,9 @@
       command: /bin/true
       notify:
         - Uninstall service
-  rescue:
+  always:
     - name: Ensure flush of handlers
       meta: flush_handlers
-  always:
     - name: End play following uninstallation
       meta: end_play
   tags:

tasks/main.yml

@@ -4,16 +4,6 @@
   tags:
     - preflight
 
-- name: Include OS and distribution specific installation tasks.
-  include_tasks: "{{ item }}"
-  with_first_found:
-    - files:
-        - "{{ ansible_distribution|lower }}/install.yml"
-        - "{{ ansible_os_family|lower }}/install.yml"
-      skip: true
-  tags:
-    - install
-
 - name: Include common installation tasks
   include_tasks: "common/install.yml"
   tags: