Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [OU-ADD] crm #3765

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[16.0] [OU-ADD] crm #3765

merged 1 commit into from
Jul 6, 2023

Conversation

marielejeune
Copy link
Contributor

No description provided.

@marielejeune marielejeune marked this pull request as ready for review March 14, 2023 14:37
@marielejeune
Copy link
Contributor Author

#3681

@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 14, 2023 •
edited by legalsylvain
Loading

/ocabot migration crm

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 14, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 14, 2023
Open
@marielejeune marielejeune force-pushed the 16.0-crm-mle branch 2 times, most recently from 835f698 to bc8cb53 Compare March 27, 2023 14:45
@marielejeune marielejeune changed the title [16.0] [MIG] crm [16.0] [OU-ADD] crm Apr 6, 2023
remytms
remytms approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

duong77476-viindoo
duong77476-viindoo reviewed Jul 1, 2023
View reviewed changes
openupgrade_scripts/scripts/crm/16.0.1.8/pre-migration.py Outdated

@openupgrade.migrate()
def migrate(env, version):
openupgrade.rename_columns(env.cr, _column_renames)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think It should be

Suggested change
openupgrade.rename_columns(env.cr, _column_renames)
openupgrade.rename_fields(env, _column_renames)

to support translation also although the openupgrade lib not support yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

This was referenced Jul 3, 2023
Merged
Merged
Merged
Merged
@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3765-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c05a637 into OCA:16.0 Jul 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c05a637. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong77476-viindoo duong77476-viindoo duong77476-viindoo approved these changes

@remytms remytms remytms approved these changes

Assignees
No one assigned
Labels
approved Dependency OK merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@marielejeune @pedrobaeza @OCA-git-bot @legalsylvain @remytms @duong77476-viindoo