Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][OU-ADD] google_gmail: Migration done #4018

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[16.0][OU-ADD] google_gmail: Migration done #4018

merged 1 commit into from
Jun 20, 2024

Conversation

ndd-odoo
Copy link
Contributor

@ndd-odoo ndd-odoo commented Jul 4, 2023

No description provided.

@legalsylvain
Copy link
Contributor

/ocabot migration google_gmail

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 4, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 4, 2023
Open
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 20, 2024
Closed
@pedrobaeza
Copy link
Member

The column use_google_gmail_service in fetchmail.server may not exists if fetchmail_gmail was not installed, so you should check the existence. Do you agree to switch to #4481 that contains this fix and the work file is rationalized by each change?

@ndd-odoo
Copy link
Contributor Author

The column use_google_gmail_service in fetchmail.server may not exists if fetchmail_gmail was not installed, so you should check the existence. Do you agree to switch to #4481 that contains this fix and the work file is rationalized by each change?

Hello @pedrobaeza , of course why not , please proceed what you have to do

@pedrobaeza
Copy link
Member

If you prefer, you can perform the if here and merge this one. I don't want to nullify your work :)

@ndd-odoo ndd-odoo force-pushed the v16_mig_google_gmail branch from 40b2c43 to 53a5975 Compare June 20, 2024 14:51
@ndd-odoo
Copy link
Contributor Author

If you prefer, you can perform the if here and merge this one. I don't want to nullify your work :)

Done, thank you sir

pedrobaeza
pedrobaeza approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to put = true in queries, but it's just a detail.

@pedrobaeza pedrobaeza merged commit ef879e6 into OCA:16.0 Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
Dependency OK needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ndd-odoo @legalsylvain @pedrobaeza @OCA-git-bot @MiquelRForgeFlow