[16.0][OU-ADD] stock_account: set display_type of cogs account move line #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinkeunen
force-pushed
the
v16_mig_stock_account
branch
2 times, most recently
from
a8184ff to
9621088
Compare
robinkeunen
changed the title
remytms
suggested changes
Feb 8, 2024
robinkeunen
changed the title
robinkeunen
force-pushed
the
v16_mig_stock_account
branch
from
9621088 to
6d00458
Compare
remytms
approved these changes
Feb 8, 2024
|
/ocabot migration stock_account |
chienandalu
reviewed
Mar 1, 2024
| stock_account / account.move.line / stock_valuation_layer_ids (one2many): NEW relation: stock.valuation.layer | ||
| stock_account / stock.valuation.layer / account_move_line_id (many2one): NEW relation: account.move.line | ||
| stock_account / stock.valuation.layer / price_diff_value (float) : NEW | ||
| # NOTHING TO DO: new feature |
There was a problem hiding this comment.
Shouldn't it be pointed that this would be addresed in purchase_stock (I'm not sure if it's necessary/possible/worth it) to rebuild past values
In v15, the lines were set to is_anglo_saxon_line == True in v16, field display_display is used.
robinkeunen
force-pushed
the
v16_mig_stock_account
branch
from
6d00458 to
213f026
Compare
|
This PR has the |
|
The explanations on the work file are very few, but let's move on with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds #3971
Nothing to do in stock_account regarding the models and views.
Fill the display type for journal items corresponding to Cost of Good Sold lines (COGS) for customer invoices. In v15, the lines were set to is_anglo_saxon_line == True, in v16 field display_display is used.
openupgrade account migration script already sets display_type in _account_move_fast_fill_display_type (pre-migration)
I struggled setting up a database issuing cogs lines so I relied on my understanding of the code to write the sql command.