[17.0][OU-ADD] enable tests, add decorator to make them convenient to use #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, @StefanRijnhart, |
hbrunn
commented
Nov 18, 2024
| if test -n "$(ls openupgrade/openupgrade_scripts/scripts/*/*/tests/data*.py 2> /dev/null)"; then | ||
| for snippet in openupgrade/openupgrade_scripts/scripts/*/*/tests/data*.py; do | ||
| if test -n "$(ls openupgrade/openupgrade_scripts/scripts/*/tests/data*.py 2> /dev/null)"; then | ||
| for snippet in openupgrade/openupgrade_scripts/scripts/*/tests/data*.py; do |
There was a problem hiding this comment.
this is because tests must live in the base directory of the addon's path
hbrunn
commented
Nov 18, 2024
| @@ -131,14 +131,16 @@ jobs: | |||
| echo Execution of Openupgrade with the update of the following modules : $MODULES_NEW | |||
| # Silence redundant logs from unlinking records (1 line is enough) | |||
| # to prevent log overflow | |||
| OPENUPGRADE_TESTS=1 $ODOO \ | |||
| $ODOO \ | |||
There was a problem hiding this comment.
the env var was a leftover from the pre-openupgrade_framework test mechanism
pedrobaeza
changed the title
pedrobaeza
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the decorator is used in the account migration.
I made this a decorator so that it doesn't interfere with the tests' metaclass.