Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] initialize+openupgrade_framework+analysis+base #4709

Draft
wants to merge 73 commits into
base: 18.0
Choose a base branch
from

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jan 13, 2025

the base migration isn't done yet, but it doesn't break with demo data any more.

At the moment this is mainly used to be sure the rest of the branch initialization and openupgrade_framework migration went right.

Left to do before we can sensibly start with migrating modules:

  • move the function to convert company dependent fields and the patch to allow (env, cr) signatures in migration functions to openupgradelib
  • make upgrade_analysis flag company dependent fields also if nothing changed (alternative would be to look at ir_properties in base's end-migration and just migrate whatever fields exist there. Seems error prone to me)
  • analyze the base analysis file more deeply

legalsylvain and others added 30 commits September 30, 2024 12:50
- Apply new copier template. (from v1.14.2 to v1.18 : replace setup by pyproject.toml, replace black by ruff, ...)
- Disable .github/workflows/test.yml because the openupgrade is not initialized yet
- add new empty modules160-170.rst file
-This commit remove unecessary patch
-Check if test exist then execute it in the test.yml
-Remove the test loader from patch, detail at
OCA#4327 (comment)
If we don't include it, /jsonrpc route doesn't work.
If you have a module in previous versions that adds data on a model,
and such model is not loaded in the registry in current version because
the module is absent in it, you can't uninstall such module, getting
this error:

  File "odoo/odoo/addons/base/models/ir_model.py", line 1945, in _module_data_uninstall
    delete(self.env[model].browse(item[1] for item in items))
  File "odoo/odoo/api.py", line 463, in __getitem__
    return self.registry[model_name]._browse(self, (), ())
  File "odoo/odoo/modules/registry.py", line 177, in __getitem__
    return self.models[model_name]
KeyError: 'model'

With this patch, data cleanup of such model is skipped and there's no crash.
…ore ; add links to the new OpenUpgrade website
MiquelRForgeFlow and others added 26 commits January 13, 2025 11:49
-This commit remove unecessary patch
-Check if test exist then execute it in the test.yml
-Remove the test loader from patch, detail at
OCA#4327 (comment)
@hbrunn hbrunn added this to the 18.0 milestone Jan 13, 2025

# Renamed modules is a mapping from old module name to new module name
renamed_modules = {
# odoo
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to check and fill this file and then redo the analysis :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.