Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][mig] mis_builder_cash_flow #1046

Closed
wants to merge 44 commits into from

Conversation

heliaktiv
Copy link
Contributor

No description provided.

jjscarafia and others added 30 commits June 7, 2023 15:48
For mis_builder to compute correctly bale we need accounts with user type include_initial_balance. We use receivable type which is the more accurate for this purpose
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-mis_builder_cash_flow/
Currently translated at 100.0% (52 of 52 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-mis_builder_cash_flow/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/
Currently translated at 100.0% (53 of 53 strings)

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/
Currently translated at 37.7% (20 of 53 strings)

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/nl/
Currently translated at 81.1% (43 of 53 strings)

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/es/
- On v13, invoices are journal entries, so we have to explicitly exclude
  cancelled invoices from the expression. We leave draft ones, as they
  are good for forecasting.
- Default value for the company of the forecast line doesn't follow new
  specification, putting an incorrect value.
- Extra improvement: avoid a non needed casting of the fixed column type.
"Target Moves" option in MIS report instance was previously ignored.

Now it's taken into account, but still excluding cancelled entries.
oca-transbot and others added 14 commits June 7, 2023 15:48
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/
Currently translated at 100.0% (55 of 55 strings)

Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/es_AR/
Currently translated at 100.0% (55 of 55 strings)

Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-mis_builder_cash_flow/it/
Currently translated at 100.0% (55 of 55 strings)

Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-mis_builder_cash_flow
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-mis_builder_cash_flow/es/
@pedrobaeza
Copy link
Member

/ocabot migration mis_builder_cash_flow

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 22, 2023
7 tasks
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use account_internal_type and not account_type in the related field?
account_internal_type = fields.Selection(
related="account_id.account_type", readonly=True
)
and change also in mis_builder_cash_flow/data/mis_report.xml from account_internal_type to account_type

Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in data/mis_report.xml
('account_internal_type', '=', 'liquidity') -> ('account_type', '=', 'asset_cash')
('account_internal_type', '=', 'receivable') -> ('account_type', '=', 'asset_receivable')
('account_internal_type', '=', 'payable') -> ('account_type', '=', 'liability_payable')

@pedrobaeza
Copy link
Member

Superseded by #1049

@pedrobaeza pedrobaeza reopened this Jun 27, 2023
@pedrobaeza pedrobaeza closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.