Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FW] account_financial_report: multiple ports from 14.0 #1233

Open
wants to merge 5 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FW] account_financial_report: multiple ports from 14.0 #1233

wants to merge 5 commits into from

Conversation

henrybackman
Copy link

@henrybackman henrybackman commented Oct 15, 2024 •
edited
Loading

@henrybackman henrybackman force-pushed the 17-port-from-14-account_financial_report branch from 5adefb5 to 032fee9 Compare October 15, 2024 11:27
mmequignon
mmequignon approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much context, but code looks good

@pedrobaeza
Copy link
Member

Well, the CI is red, so first, that should be fixed.

@mmequignon
Copy link
Member

Well, the CI is red, so first, that should be fixed.

You're right, I missed this, user_type_id has been replaced by account_type (Many2one to Selection)

@henrybackman
Copy link
Author

Well, the CI is red, so first, that should be fixed.

You're right, I missed this, user_type_id has been replaced by account_type (Many2one to Selection)

Yes, this was the existing issue and it has now been resolved by changing the field in General Ledger Wizard to account_type as well. This however means that the wizard supports only one account type instead of many, but it was considered that expanding to multiple was beyond the scope of the forward porting.

jdidderen-be and others added 4 commits October 22, 2024 13:24
@jdidderen-be @henrybackman
[FIX] account_financial_report - fix abstract report class name
282b303
@toita86 @henrybackman
[IMP] account_financial_report: localize date format on VAT report
1680645 
Before this change, the date format in the VAT report print was not sensible to the company's localization.
The date string has been converted to a Date field to ensure the correct format aligns with the company's localization.
@toita86 @henrybackman
[IMP] account_financial_report: VAT report fields translation
bd23f55
@WesleyOliveira98 @henrybackman
[IMP] account_financial_report: general ledger filter by account types
245b141
@henrybackman henrybackman force-pushed the 17-port-from-14-account_financial_report branch from 93daacf to 520d07a Compare October 22, 2024 11:27
@henrybackman
[FIX] account_financial_report: fix account_type field
f980e17 
When porting from v14 to v17, the `account_account.user_type_id`
has been changed to `account_type`. Previously `general_ledger_wizard`
was able to store multiple account types through the `account_type_ids`
field. To simplify the forward porting, for now only one `account_type`
can be selected in the wizard.
@henrybackman henrybackman force-pushed the 17-port-from-14-account_financial_report branch from 520d07a to f980e17 Compare October 22, 2024 11:31
@henrybackman
Copy link
Author

@WesleyOliveira98 While forward porting your changes, I made a change to the General Ledge Wizard to accommodate changes in 17.0. This has a functional impact:

  • Before it was possible to select multiple account types but I implemented a simplified fix which allows selecting only a single account type

Could I ask you to review the port and my changes?
Fix commit:

This was referenced Nov 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmequignon mmequignon mmequignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@henrybackman @pedrobaeza @mmequignon @jdidderen-be @toita86 @WesleyOliveira98