Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_ecotax_sale: Migration to 17.0 #481

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] account_ecotax_sale: Migration to 17.0 #481

wants to merge 14 commits into from

Conversation

mourad-ehm
Copy link
Contributor

No description provided.

@mourad-ehm
Copy link
Contributor Author

@florian-dacosta

vvrossem
vvrossem approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vvrossem vvrossem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
pre-approving: module version needs to be corrected

@mourad-ehm
Copy link
Contributor Author

Hi @vvrossem, Thanks for review. I accepted your commit suggestions

mourad-ehm and others added 13 commits March 4, 2025 15:28
@mourad-ehm
[16.0] add account_ecotax_sale module
8f9cc68
@bealdav @mourad-ehm
FIX acc_ecotax_sale: subtotal_ecotax computing
f45c902
@bealdav @mourad-ehm
fixup
feeb438
@mourad-ehm
Update sale_order_line.py
f0e58d2 
Compute method dependency
@mourad-ehm
[16.0] delete migration script & fix typo & Ecotax lines is readonly
7523de5
@mourad-ehm
FIX test
c33e911
@florian-dacosta @mourad-ehm
[REF] Split account_ecotax_sale into account_ecotax_sale and account_…
9823dc9 
…ecotax_sale_tax
@florian-dacosta @mourad-ehm
[IMP] Convert onchange to compute to create sale ecotax lines to impr…
6f5d6e1 
…ove reliability (when sol is not created/update from UI)
@florian-dacosta @mourad-ehm
[FIX] sale_order_line_ecotax created without classification when gene…
99e84d4 
…rated from UI
@mourad-ehm
[IMP] account_ecotax_sale: pre-commit auto fixes
528a3fc
@mourad-ehm
[MIG] account_ecotax_sale: Migration to 17.0
0be463a
@mourad-ehm
[FIX] account_ecotax_sale: add test-requirement
0921fdf
@mourad-ehm
[FIX] account_ecotax_sale: remove test-requirements.txt
3d9fec5
@mourad-ehm mourad-ehm force-pushed the 17.0-mig-account_ecotax_sale branch from a0f6106 to 3d9fec5 Compare March 4, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilvioC2C SilvioC2C SilvioC2C left review comments

@vvrossem vvrossem vvrossem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mourad-ehm @vvrossem @SilvioC2C @bealdav @florian-dacosta