-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] account_invoice_report_utm_campaign : adds Campaign, Medium, and Source to analysis report #335
[14.0][ADD] account_invoice_report_utm_campaign : adds Campaign, Medium, and Source to analysis report #335
Conversation
84f8a0d
to
144f6c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank
"website": "https://github.com/OCA/account-invoice-reporting", | ||
"author": "Akretion, Odoo Community Association (OCA)", | ||
"license": "AGPL-3", | ||
"installable": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forget to add yourself as maintainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(resolved)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contribution, works as expected. Thanks @nayatec
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at ffeb2f2. Thanks a lot for contributing to OCA. ❤️ |
Why it is called |
Hello @pedrobaeza you have a point here... As a matter of fact i named it after another module we made with a similar name because we thought that "utm_campaign" helps to better contextualize the module. I'll rename it when proposing the migration. |
This module adds the Campaign, Medium, and Source fields to the Invoice Analysis report.