Fix pip install + Others things #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing that the service is running on http://localhost:8069 + Fix the description of 'pip' install type in README + Restart Odoo if the application of the pip requirements.txt file has triggered changes + Set the default 'odoo_version' to 11.0
…tion + install PyPDF 1.13 on Debian Stretch for Odoo 8, 9 and 10 (not PyPDF2)
… the Odoo archive from https://nightly.odoo.com instead of https://github.com/odoo/odoo, the first contains all standard modules in the 'addons/' folder, not the second
|
Ok. Seems good! Let's wait then for Travis to finalize. What about wkhtmltopdf? We have been working with 0.12.4 in v11 and works well. |
|
It needs some work to install wkhtmltopdf from .deb package for 0.12.1 (done partially) and from the .tar.gz for 0.12.4. It's on my roadmap. |
|
@jbeficent and do you know how behave wkhtmltopdf 0.12.4 with Odoo 8/9/10 ? Is it compatible? |
|
We have been using 0.12.4 in v9, v10 and v11 with success. |
|
But I think that it was patched. |
JordiBForgeFlow
approved these changes
Jan 25, 2018
|
Okay, I'll do some tests locally regarding wkhtmltopdf 0.12.4 on Debian Stretch and Odoo 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbeficent unfortunately Travis tests were broken (and since a long time!).
I also fixed the
odoo_pip_odoo_bin_pathvariable to handle Odoo < 10 (./odoo.py) and Odoo >= 10 (./odoo) + the ownership of files generated through pip.Your review is welcome.