Fixes mostly to pip install #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
reviewed
Feb 15, 2018
defaults/main.yml
Outdated
| @@ -71,7 +71,7 @@ odoo_config_limit_time_real_cron: -1 # >= 10.0 | |||
| odoo_config_list_db: True | |||
| odoo_config_log_db: False | |||
| odoo_config_log_level: info | |||
| odoo_config_logfile: None | |||
| odoo_config_logfile: "/var/log/{{ odoo_user }}/{{ odoo_user }}.log" | |||
There was a problem hiding this comment.
I'm not sure about this:
- The init script (and systemd unit) already configure the logfile option (https://github.com/OCA/ansible-odoo/blob/master/templates/odoo-pip.init#L23 , and they are using
odoo_logdirandodoo_serviceto be compatible with multi odoo instances on one server). - If this option stay undefined, it allows to run the server manually (dev/debug/update purpose) with the logs on the standard output
| - name: Create odoo data dir directory | ||
| file: path={{ odoo_config_data_dir }} state=directory | ||
| owner={{ odoo_user }} group={{ odoo_user }} force=yes | ||
|
|
There was a problem hiding this comment.
Odoo is not able to handle this case by its own?
There was a problem hiding this comment.
No, it fails because the dir does not exist.
templates/odoo-pip.service
Outdated
| @@ -6,7 +6,7 @@ After=network.target | |||
| Type=simple | |||
| User={{ odoo_user }} | |||
| WorkingDirectory={{ odoo_workdir }} | |||
| ExecStart={{ odoo_pip_odoo_bin_path }} | |||
| ExecStart={{ odoo_pip_odoo_bin_path }} --config {{ odoo_config_file }} | |||
There was a problem hiding this comment.
👍 And the other odoo-standard.service file need the same fix.
sebalix
requested changes
Feb 16, 2018
templates/odoo-pip.init
Outdated
| @@ -40,7 +41,7 @@ function _start() { | |||
| # from the configuration file | |||
| # Odoo: https://github.com/odoo/odoo/pull/13685 | |||
| # OCB: https://github.com/OCA/OCB/pull/553 | |||
| start-stop-daemon --chdir=${WORKDIR} --start --quiet --pidfile $PIDFILE --chuid $USER:$USER --background --make-pidfile --exec $DAEMON -- --logfile $LOGFILE{{ odoo_config_server_wide_modules not in [False, 'None', ''] and ' --load=%s' % odoo_config_server_wide_modules or '' }} | |||
| start-stop-daemon --chdir=${WORKDIR} --start --quiet --pidfile $PIDFILE --chuid $USER:$USER --background --make-pidfile --exec $DAEMON --config $CONFIG --logfile $LOGFILE{{ odoo_config_server_wide_modules not in [False, 'None', ''] and ' --load=%s' % odoo_config_server_wide_modules or '' }} | |||
There was a problem hiding this comment.
You removed the double-dash -- just before --config. It is mandatory to separate start-stop-daemon options from Odoo ones.
JordiBForgeFlow
force-pushed
the
master-odoo_config_data_dir
branch
from
fd82c44 to
e801b88
Compare
- increases the default values for limit_memory_soft and limit_memory_hard, as the previous were obsolete, applicable to openerp 7.0
JordiBForgeFlow
force-pushed
the
master-odoo_config_data_dir
branch
from
56c6835 to
0c8e963
Compare
|
Providing wrong memory defaults can ruin your weekend! The PR also introduces fixes to #72 |
sebalix
approved these changes
Feb 18, 2018
pedrobaeza
approved these changes
Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding some fixes as I am getting more on hands with it. Specifically to the pip install.
But I also found that we need a default path for logging of odoo. Otherwise one can forget to add it to the playbook and the logs are then lost.