[FIX] Let systemd/journalctl handles the logs by default + new variable 'odoo_logfile'... #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le 'odoo_logfile' for other init systems (log files are then managed by Odoo itself). If the operator wants Odoo to handles the log files while using systemd, the value of 'odoo_logfile' can be set and the '--logfile' Odoo parameter will be configured.
JordiBForgeFlow
approved these changes
Mar 19, 2018
|
@jbeficent thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for other init systems (log files are then managed by Odoo itself).
If the operator wants Odoo to handle the log files while using systemd, the value of
odoo_logfilecan be set as any other role variable and the--logfileOdoo parameter will be configured in the systemd unit file.And fix the Buildout systemd unit service to be coherent with pip and standard service unit files.
The first commit change the way we access logs by default if
systemdis used: logs have to be read with thejournalctltool.The second one has been copied from the upstream Odoo unit file (odoo/odoo@ee753bf) to avoid killing Odoo and all its workers instantly when stopping the service, and instead let the process finishes its tasks before exiting.