Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] New options 'odoo_user_ssh_key' and 'odoo_user_ssh_known_hosts'… #84

Merged
merged 1 commit into from
May 4, 2018

Conversation

sebalix
Copy link
Collaborator

@sebalix sebalix commented Mar 28, 2018

… to configure/copy SSH private (without passphrase) and public keys with the Odoo user allowing to clone private Git/Mercurial repositories (via the odoo_repo_url or indirectly with buildout install type).

The public key should be added on the different services (BitBucket, GitHub, GitLab...).

Fixing #82

odoo_user_ssh_key:
    priv: "path/to/local/private_key"
    pub:  "path/to/local/public_key.pub"
odoo_user_ssh_known_hosts:
    - bitbucket.org
    - github.com
    - gitlab.com
    - src.company.net

Ping @aheficent

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Mar 28, 2018

I'm only here because this project's 42(!) test jobs are and will be blocking the testing of my own PR on another OCA project for quite some time. Is there anything we can do about that?

@sebalix
Copy link
Collaborator Author

sebalix commented Mar 28, 2018

@StefanRijnhart well, that's a real problem, and I would love to reduce the time needed to test all these options too...
If we put all the tests in one Travis job, it will make the other processes available for other OCA projects? The CI output will be more difficult to read but if it's the only option I can do that.

@StefanRijnhart
Copy link
Member

Indeed. The OCA has a number of concurrent jobs at Travis, so if a PR on this project only occupies one slot at the time it would allow other PRs to run simultaneously.

@StefanRijnhart
Copy link
Member

Oh no. You just had a single job failing due to some Github glitch. In the current configuration you can just restart the one job instead of having to sit through another run of the one monolithic job you are proposing above. Do you think that instead, OCA can configure its Travis differently so that multiple slots cannot be occupied by jobs from the same PR if there is a waiting queue?

@StefanRijnhart
Copy link
Member

To answer my question, it can! 'limit the number of concurrent jobs on a per project basis' https://blog.travis-ci.com/2014-07-18-per-repository-concurrency-setting. Let me file a request at mqt.

@sebalix
Copy link
Collaborator Author

sebalix commented Mar 28, 2018

@StefanRijnhart sorry, didn't see that another CI build was running, I thought all was finished... I stopped the remaining jobs, there is no urgency, I'll rerun them later.
About your suggestion: 👍
I'm also thinking about a refactoring of the tests in one job to use an APT cache, pip cache, etc, to speed up the tests.

@StefanRijnhart
Copy link
Member

OCA/maintainer-quality-tools#534. Using caching as much as possible seems a good idea too.

@JordiBForgeFlow
Copy link
Member

@sebalix This one can be merged, right?

@sebalix
Copy link
Collaborator Author

sebalix commented Apr 26, 2018

@jbeficent yes you can merge.
Nothing related to this PR, I except that the build will fail due to the new pip version + something related to setuptools (https://travis-ci.org/sebalix/ansible-odoo/builds/368646043). Both pip and buildout install type are impacted, I have no fix ATM.

@sebalix
Copy link
Collaborator Author

sebalix commented May 3, 2018

Depends on #87

… to configure SSH private (without passphrase) and public keys with the Odoo user allowing to clone private Git/Mercurial repositories (via the 'odoo_repo_url' or indirectly with 'buildout' install type)
@sebalix sebalix force-pushed the dev/handle_ssh_keys branch from 4e5934c to 7d7668e Compare May 3, 2018 09:44
@JordiBForgeFlow
Copy link
Member

This is now ready to merge.

@sebalix
Copy link
Collaborator Author

sebalix commented May 4, 2018

Thanks Jordi, merging.

@sebalix sebalix merged commit bb855f4 into OCA:master May 4, 2018
@sebalix sebalix deleted the dev/handle_ssh_keys branch May 4, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants