-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] New options 'odoo_user_ssh_key' and 'odoo_user_ssh_known_hosts'… #84
Conversation
I'm only here because this project's 42(!) test jobs are and will be blocking the testing of my own PR on another OCA project for quite some time. Is there anything we can do about that? |
@StefanRijnhart well, that's a real problem, and I would love to reduce the time needed to test all these options too... |
Indeed. The OCA has a number of concurrent jobs at Travis, so if a PR on this project only occupies one slot at the time it would allow other PRs to run simultaneously. |
Oh no. You just had a single job failing due to some Github glitch. In the current configuration you can just restart the one job instead of having to sit through another run of the one monolithic job you are proposing above. Do you think that instead, OCA can configure its Travis differently so that multiple slots cannot be occupied by jobs from the same PR if there is a waiting queue? |
To answer my question, it can! 'limit the number of concurrent jobs on a per project basis' https://blog.travis-ci.com/2014-07-18-per-repository-concurrency-setting. Let me file a request at mqt. |
@StefanRijnhart sorry, didn't see that another CI build was running, I thought all was finished... I stopped the remaining jobs, there is no urgency, I'll rerun them later. |
OCA/maintainer-quality-tools#534. Using caching as much as possible seems a good idea too. |
@sebalix This one can be merged, right? |
@jbeficent yes you can merge. |
Depends on #87 |
… to configure SSH private (without passphrase) and public keys with the Odoo user allowing to clone private Git/Mercurial repositories (via the 'odoo_repo_url' or indirectly with 'buildout' install type)
4e5934c
to
7d7668e
Compare
This is now ready to merge. |
Thanks Jordi, merging. |
… to configure/copy SSH private (without passphrase) and public keys with the Odoo user allowing to clone private Git/Mercurial repositories (via the
odoo_repo_url
or indirectly withbuildout
install type).The public key should be added on the different services (BitBucket, GitHub, GitLab...).
Fixing #82
Ping @aheficent