Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to force reinstall pip packages in pip install method #89

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

JordiBForgeFlow
Copy link
Member

This option is required to ensure that the latest OCA modules are always installed. Otherwise you get errors when a new version of an OCA module is released.

For example, when you specify in the requirements file this package:
odoo11-addon-auth_brute_force

This will install in fact the latest package from https://wheelhouse.odoo-community.org/oca-simple/odoo10-addon-auth-brute-force/

The next time you run ansible, if a new version of the module has been released, you will want to install it.

The current --upgrade option is giving errors because it is still expecting older versions of packages.

This will increase the time to run the playbook, but it is way more reliable IMHO.

Perhaps @sbidoul knows better.

@sbidoul
Copy link
Member

sbidoul commented Jun 22, 2018

Is this an ansible-specific issue? What kind of error do you get?

@JordiBForgeFlow
Copy link
Member Author

@sbidoul was complaining that it expected odoo10_addon_auth_brute_force-10.0.1.0.0.99.dev2 , but had odoo10_addon_auth_brute_force-10.0.1.0.0.99.dev3, which makes no sense to me. When I forced the reinstall the problem was resolved.

Copy link
Collaborator

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time doesn't seem to increase a lot compared to previous Travis tests 👍

@sebalix sebalix merged commit 1eb72cb into OCA:master Jul 5, 2018
@LoisRForgeFlow LoisRForgeFlow deleted the master-pip-forcereinstall branch July 6, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants