Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_statement_import_online_gocardless: IBAN comparison #686

Commits on Aug 8, 2024

  1. [FIX] account_statement_import_online_gocardless: IBAN comparison

    It is possible that, when making the request to the requisitions endpoint,
    the IBAN bank account comes with a lower alphanumeric string.
    When comparing with the sanitized bank account (stored with upper) fails.
    
    self.journal_id.bank_account_id.sanitized_acc_number == account_data["iban"]
    
    to
    
    self.journal_id.bank_account_id.sanitized_acc_number == account_data["iban"].upper()
    
    Refactor method _gocardless_finish_requisition to be able to mock the requests made inside and create a unit test.
    Refactor requests methods.
    ljsalvatierra-factorlibre committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cd01ed0 View commit details
    Browse the repository at this point in the history