Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] account_statement_import_sheet_file: Improve readme #724

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from

Conversation

florenciafrigieri2
Copy link

Improving readme. Adding context.

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort. Some small comments. Can you review them?

account_statement_import_sheet_file/readme/CONFIGURE.md Outdated Show resolved Hide resolved
@@ -0,0 +1,15 @@
BUSINESS NEED:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest

Business need
~~~~~~~~~~~~~

The same for all titles

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the idea! I'll take the suggestion to the functional group since the titles are not right now in the template, and we should change that first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you should compare how it is seen in both cases:

Old:

Captura desde 2024-10-17 07-35-14

New:

image

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from comments from @etobella LGTM

@florenciafrigieri2
Copy link
Author

@etobella Can you solve the squash thing please?

@florenciafrigieri2
Copy link
Author

@etobella Hello!! Can you please merge this :)?

@etobella
Copy link
Member

@florenciafrigieri2 I am waiting for functional group's answer to my proposal of format. I made a small picture of how it is seen with both options and I made a commit in order to keep your original commit (in case the functional group wants to go back)

@vdewulf
Copy link

vdewulf commented Oct 21, 2024

I answered to Flor and other people on our Discord channel, I like Enric's suggestion. I think it's easier to read.
Very nice new content in any case :)

@TumbaoJu
Copy link

I also like the use of headers to structure the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants