-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][IMP] account_statement_import_sheet_file: Improve readme #724
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @alexey-pelykh, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort. Some small comments. Can you review them?
@@ -0,0 +1,15 @@ | |||
BUSINESS NEED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest
Business need
~~~~~~~~~~~~~
The same for all titles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the idea! I'll take the suggestion to the functional group since the titles are not right now in the template, and we should change that first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from comments from @etobella LGTM
@etobella Can you solve the squash thing please? |
@etobella Hello!! Can you please merge this :)? |
@florenciafrigieri2 I am waiting for functional group's answer to my proposal of format. I made a small picture of how it is seen with both options and I made a commit in order to keep your original commit (in case the functional group wants to go back) |
I answered to Flor and other people on our Discord channel, I like Enric's suggestion. I think it's easier to read. |
I also like the use of headers to structure the file. |
Improving readme. Adding context.