Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] hr_phone: Migration to 16.0 #297

Closed
wants to merge 24 commits into from

Conversation

nguyenminhchien
Copy link

Alexis de Lattre and others added 22 commits March 16, 2023 15:17
- move more asterisk-independant code to base_phone module and create new asterisk-independant modules
- rename module asterisk_popup to base_phone_popup
- add ability to get callerid names not only from partners, but also from leads, employees, applicants, etc...
- same for auto pop-up : not only for partners, but also for leads, employees, etc...
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
… from the country of the object (partner, lead, hr.applicant), not from the country of the user... a very wanted feature !
Use the new phone attributes on objects inside the code
Proper name_get for callerid for applicants
Small bugfixes/enhancements
The revolution in the connector-telephony project has started !
Remove crm_claim_phone, because there is no crm_claim module in v10
Start to port asterisk_click2dial (JS code still needs to be ported)
Migrate README to the new subdir format
@StephaneMangin
Copy link

For the PR dependency, please take in account this comment OCA/edi#724 (comment)

@mmequignon
Copy link
Member

mmequignon commented May 11, 2023

Could you please address this comment?
#296 (comment)

@nilshamerlinck
Copy link

Hello @mmequignon

  • your remark in previous PR has been taken into account: the old mixin has been removed in this PR and the code relies on odoo native's _phone_format that uses odoo.addons.phone_validation.tools.phone_format indeed
  • base_phone comes with some other features (wizards, widget), and is needed for other modules such crm_phone
  • that said if you think it's worth it, we will work on a new PR for an hr_phone that doesn't depend on base_phone anymore

@mmequignon
Copy link
Member

Hello @mmequignon

* your remark in previous PR has been taken into account: the old mixin has been removed in this PR and the code relies on odoo native's [`_phone_format`](https://github.com/odoo/odoo/blob/16.0/addons/phone_validation/models/res_partner.py#L21) that uses `odoo.addons.phone_validation.tools.phone_format` indeed

* `base_phone` comes with some other features (wizards, widget), and is needed for other modules such `crm_phone`

* that said if you think it's worth it, we will work on a new PR for an `hr_phone` that doesn't depend on `base_phone` anymore

my bad, I thought the previous pr has just been reopened.
I'll update my review, please ignore my previous comment.
Sorry for the noise!

Copy link

@florentx florentx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1 @@
odoo-addon-base_phone @git+https://github.com/OCA/connector-telephony@refs/pull/296/head#subdirectory=setup/base_phone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
odoo-addon-base_phone @git+https://github.com/OCA/connector-telephony@refs/pull/296/head#subdirectory=setup/base_phone
odoo-addon-base_phone @git+https://github.com/OCA/connector-telephony@refs/pull/300/head#subdirectory=setup/base_phone

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florentx : updated

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 24, 2023
@github-actions github-actions bot closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.