[17.0][IMP] account_credit_control: Allow to create credit control lines with the maximum level for one control run #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-teruel
changed the title
carlosdauden
approved these changes
Feb 20, 2025
| @@ -32,6 +35,11 @@ class CreditControlPolicy(models.Model): | |||
| help="This policy will be active only for the selected accounts", | |||
| ) | |||
| active = fields.Boolean(default=True) | |||
| apply_max_policy_level = fields.Boolean( | |||
| string="Apply max policy level", | |||
| help="Apply max policy lavel for one partner in a credit control run execution " | |||
There was a problem hiding this comment.
Suggested change
| help="Apply max policy lavel for one partner in a credit control run execution " | |
| help="Apply max policy level for one partner in a credit control run execution " |
| default_apply_max_policy_level = fields.Boolean( | ||
| string="Apply max policy level", | ||
| default_model="credit.control.policy", | ||
| help="Apply max policy lavel for one partner in a credit control run execution " |
There was a problem hiding this comment.
Suggested change
| help="Apply max policy lavel for one partner in a credit control run execution " | |
| help="Apply max policy level for one partner in a credit control run execution " |
| <field name="invoice_id" /> | ||
| <field name="partner_id" /> | ||
| <field name="partner_id" readonly="true" /> |
There was a problem hiding this comment.
Suggested change
| <field name="partner_id" readonly="true" /> | |
| <field name="partner_id" readonly="True" /> |
It probably works correctly, but the usual way is to use it with a capital T or readonly="1".
carlos-lopez-tecnativa
suggested changes
Feb 20, 2025
sergio-teruel
force-pushed
the
17.0-IMP-account_credit_control-some-improvements
branch
2 times, most recently
from
f2df5f6 to
10cac52
Compare
|
Changes done!! |
carlos-lopez-tecnativa
suggested changes
Feb 21, 2025
…the maximum level for one control run Some ux improvements and minor fixes
sergio-teruel
force-pushed
the
17.0-IMP-account_credit_control-some-improvements
branch
from
10cac52 to
ed0fbf4
Compare
carlos-lopez-tecnativa
approved these changes
Feb 21, 2025
|
This PR has the |
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1e909d6. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
17.0-IMP-account_credit_control-some-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT55185
ping @carlosdauden @carlos-lopez-tecnativa