[18.0][MIG] website_sale_checkout_country_vat: Migration to version 18.0 #1027
Conversation
…e in website checkout form.
Replace settings with sane defaults. Update VAT flag when address country is updated.
If you leave country field empty before pressing the confirm button at checkout, you were getting a 500 error because `country_id` was `""` (str), which cannot be searched in an int field. Now we set a default `False` value, which will return an empty recordset without that problem.
Add is-invalid class to the input tag when an error is received
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks. Fixed by inheriting from the correct view. Also benefits from OCA/website#720 by using readonly mode if that module is updated. @Tecnativa TT17694 [1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
| [website_sale_default_country](https://github.com/OCA/e-commerce/tree/10.0/website_sale_default_country) | ||
| module. |
There was a problem hiding this comment.
This module has not been migrated from V11 onwards. Does it need to be referenced here?
|
/ocabot migration website_sale_checkout_country_vat |
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_checkout_country_vat
branch
from
df8a7fe to
8266009
Compare
You can check again
This is a matter of the base module and the way it has always worked. But it actually does the search when you select the country in the address. I think the module is meant for when you define new addresses, not when you modify them. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at d8a3e37. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT54387
@carlos-lopez-tecnativa @CarlosRoca13 please review