Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_invoice_ubl #886

Open
wants to merge 67 commits into
base: 16.0
Choose a base branch
from

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Dec 11, 2023

@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch 6 times, most recently from 8377e58 to 6e33437 Compare December 17, 2023 22:27
@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch 3 times, most recently from 74754e9 to a22a4bc Compare December 26, 2023 10:58
@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch 5 times, most recently from fcbfb09 to ff7c22b Compare December 27, 2023 15:09
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
@github-actions github-actions bot closed this Aug 18, 2024
@jbaudoux
Copy link
Contributor Author

@OCA/edi-maintainers Could you reopen this PR?

@etobella etobella reopened this Aug 19, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code + functionnal)

@lmignon
Copy link
Contributor

lmignon commented Oct 18, 2024

@jbaudoux a little rebase seems to be required...

@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch from 847ded0 to cf8e915 Compare December 4, 2024 11:32
@jbaudoux
Copy link
Contributor Author

jbaudoux commented Dec 4, 2024

  • Rebased
  • Fixed non product invoice lines to exclude them from UBL. Generation was crashing with AssertionError: name is a required arg
  • dropped merged PR from test-requirements.txt

@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch from cf8e915 to 378e794 Compare December 4, 2024 11:42
oca-travis and others added 24 commits December 4, 2024 16:38
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-14.0/edi-14.0-account_invoice_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_ubl/
Currently translated at 100.0% (13 of 13 strings)

Translation: edi-14.0/edi-14.0-account_invoice_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_ubl/es/
* Fix unit price, declare discount (must be declared to prevent rounding issue)

* Support non-VAT taxes: Declare non-VAT taxes as global extra charge
Peppol does not allow to have multiple taxes declaration exempt of VAT.
Regroup them in one declaration with the sum of the amounts.
A credit note must follow a dedicated schema
A credit note must not have a DueDate
Do not provide payment means & terms on a credit note
@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch from 378e794 to ca16013 Compare December 4, 2024 15:38
@jbaudoux jbaudoux added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Dec 4, 2024
lmignon and others added 3 commits December 4, 2024 18:05
The report_ref can be one of:
    - ir.actions.report id
    - ir.actions.report record
    - ir.model.data reference to ir.actions.report
    - ir.actions.report report_name
Ensures to retrieve tne report name from a report_ref accordingly.
In case of tax exempt invoice where lines have a tax without repartition lines, declare tax based on the tax of the line
@jbaudoux jbaudoux force-pushed the 16.0-mig-account_invoice_ubl branch from ca16013 to 75e5833 Compare December 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.