-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] hr_employee_calendar_planning #1086
[15.0][MIG] hr_employee_calendar_planning #1086
Conversation
Hey @pegonzalezspesol, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Please, cherry pick #1094 |
Please, cherry pick #1095 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't remove tests, It is very important to validate all use cases.
This module allows to manage employee working time with profiles by date intervals. The profiles are regular working time calendars, but they are treated as master ones here, allowing you to compose complexes working times by dates. Under the hook, a unique working time is created for each employee with the proper composition for not affecting the rest of the functionality linked to this model. Installation ============ During the installation of the module, current working times are split by start/end dates for having consistent data, and the potential new composed calendar planning is saved instead on the employee. Configuration ============= 1. Go to *Employees > Employees*. 2. Open or create a new one. 3. On the "Public Information" page, fill the section "Calendar planning" with: * Starting date (optional). * Ending date (optional). * Working time to apply during that date interval. Known issues / Roadmap ====================== * Add a wizard for generating next year calendar planning based on current one in batch. * Add constraint for avoiding planning lines overlapping. * Avoid the regeneration of whole private calendars each time a change is detected.
Add _description for model hr.employee.calendar to make it pass runbot.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-13.0/hr-13.0-hr_employee_calendar_planning Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-hr_employee_calendar_planning/
- On the module init, existing employee calendar leaves should be linked to the employee's new autocalendar.
Currently translated at 94.4% (17 of 18 strings) Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
…even when calendar is not active. TT31606
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
…weeks. Regenerate automatic calendar correctly when calendars are 2 weeks old (or any of them are 2 weeks old). TT32425
…r if calendars have been defined in employee creation. TT32425
Currently translated at 100.0% (22 of 22 strings) Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/ca/
…void create employees without calendar planing. TT35897
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
Parent is not necessary on context, this returns the next error when you try to select a calendar planning on the employee: ``Uncaught Error: NameError: name 'parent' is not defined``
32d4edd
to
2e89948
Compare
@victoralmau PR rebased with latests 14.0 status. Can you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review OK.
/ocabot migration hr_employee_calendar_planning |
_("%s is used in %s employee(s). You should change them first.") | ||
% (item.name, total_items) | ||
_( | ||
"%(item_name)s is used in %(total_items)s employee(s)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update at least Spanish translation?
@classmethod | ||
def setUpClass(cls): | ||
super().setUpClass() | ||
super(TestHrEmployeeCalendarPlanning, cls).setUpClass() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need of this diff. It was OK before
Can you apply the latest changes to merge it? |
Please, cherry-pick #1128 |
Superseed by #1138 |
Work done: