Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [ADD] hr_employee_as_partner #1117

Closed
wants to merge 1 commit into from
Closed

[14.0] [ADD] hr_employee_as_partner #1117

wants to merge 1 commit into from

Conversation

paradoxxxzero
Copy link

No description provided.

@paradoxxxzero paradoxxxzero marked this pull request as draft May 31, 2022 09:13
@nimarosa
Copy link
Contributor

Correct me if I'm wrong but in employee form the partner is created when you add the address fields, that are stored in partner model. So which is the use of this?

@paradoxxxzero
Copy link
Author

The use case is to communicate with an employee (not a user) on a professional address (not on the private one).

@paradoxxxzero paradoxxxzero marked this pull request as ready for review September 26, 2022 09:48
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 29, 2023
PierrickBrun
PierrickBrun approved these changes Feb 2, 2023
View reviewed changes
Copy link

@PierrickBrun PierrickBrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hieulucky111
hieulucky111 approved these changes Feb 24, 2023
View reviewed changes
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code Review

@github-actions github-actions bot closed this Mar 26, 2023
@hparfr
Copy link

hparfr commented Mar 27, 2023

@nimarosa can we have this PR merged ?

@nimarosa nimarosa reopened this Mar 29, 2023
@nimarosa
Copy link
Contributor

@hparfr Hello, I reopened the PR but you need to rebase it and also fix CI errors for this to be merged.

@nimarosa nimarosa removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 29, 2023
@nimarosa
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@nimarosa The rebase process failed, because command git push --force akretion tmp-pr-1117:14.0-hr_employee_as_partner failed with output:

remote: Permission to akretion/hr.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/akretion/hr/': The requested URL returned error: 403

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 30, 2023
@hparfr hparfr force-pushed the 14.0-hr_employee_as_partner branch from fc488d5 to 7b81898 Compare August 25, 2023 09:39
@hparfr
Copy link

hparfr commented Aug 25, 2023

@nimarosa
rebased as requested

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 27, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 31, 2023
@github-actions github-actions bot closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieulucky111 hieulucky111 hieulucky111 approved these changes

@PierrickBrun PierrickBrun PierrickBrun approved these changes

@hparfr hparfr hparfr approved these changes

Assignees
No one assigned
Labels
approved stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paradoxxxzero @nimarosa @hparfr @OCA-git-bot @PierrickBrun @hieulucky111