Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] Importação de Extrato Bancário CNAB 240 - Segmento E #1030

Merged
merged 1 commit into from
Mar 16, 2021
Merged

[12.0] Importação de Extrato Bancário CNAB 240 - Segmento E #1030

merged 1 commit into from
Mar 16, 2021

Conversation

mileo
Copy link
Member

@mileo mileo commented Nov 13, 2020 •
edited
Loading

@rvalyi
Copy link
Member

rvalyi commented Nov 17, 2020

(aprovei seu PR do testes la starkbank/febraban-python#27 que seria o começo, vamos ver se os autores sao reativos)

@mileo
Copy link
Member Author

mileo commented Nov 17, 2020

(aprovei seu PR do testes la starkbank/febraban-python#27 que seria o começo, vamos ver se os autores sao reativos)

São sim, até estou em contato com eles no Telegram. Entretanto eles estão bem enrolados com o PIX, creio que isso só melhore no final do ano.

@renatonlima renatonlima force-pushed the 12.0 branch 5 times, most recently from 7b2f6a6 to 6100848 Compare January 8, 2021 14:30
@mileo mileo force-pushed the feature/cnab-statement-import branch 2 times, most recently from 8f202c3 to 56ed57d Compare March 1, 2021 00:19
@mileo
Copy link
Member Author

mileo commented Mar 1, 2021 •
edited
Loading

Pessoal já fazem 4 meses que estamos esperando a revisão do pessoal do banco @starkbank para prosseguir com o PR.

Eu acabei fechando uma versão:

https://github.com/erpbrasil/febraban-python/releases/tag/v0.7.1

Tem testes automatizados e o coverage do extrato esta bem alto:

https://codecov.io/gh/erpbrasil/febraban-python/tree/master/febraban/cnab240/statement

@mileo mileo requested review from mbcosta, renatonlima, marcelsavegnago, jcarvalhido and rvalyi and removed request for mbcosta March 1, 2021 00:20
@mileo mileo force-pushed the feature/cnab-statement-import branch 2 times, most recently from 6d07ee5 to da32636 Compare March 1, 2021 02:27
@mileo mileo force-pushed the feature/cnab-statement-import branch 2 times, most recently from cc38715 to 0dfe0d6 Compare March 16, 2021 09:11
@mileo
Copy link
Member Author

mileo commented Mar 16, 2021

@gabrielcardoso21 @rvalyi @renatonlima @marcelsavegnago @marcos-mendez podem revisar por gentileza?

@marcelsavegnago
Copy link
Member

@mileo consegue tratar os erros do travis por favor ?

@mileo
Copy link
Member Author

mileo commented Mar 16, 2021

@mileo consegue tratar os erros do travis por favor ?

Puts eu já tinha resolvido essas coisas.... Mas fui dar rebase hj e acabei subindo commit antigo, vou ter que fazer de novo.

@mileo mileo force-pushed the feature/cnab-statement-import branch from 0dfe0d6 to 88c513f Compare March 16, 2021 16:48
@marcelsavegnago
Copy link
Member

@mileo consegue tratar os erros do travis por favor ?

Puts eu já tinha resolvido essas coisas.... Mas fui dar rebase hj e acabei subindo commit antigo, vou ter que fazer de novo.

eita :D

@mileo
Copy link
Member Author

mileo commented Mar 16, 2021

Puts eu já tinha resolvido essas coisas.... Mas fui dar rebase hj e acabei subindo commit antigo, vou ter que fazer de novo.

Mas recuperei kkkk, pycharm salva.

@mileo mileo force-pushed the feature/cnab-statement-import branch from 88c513f to b18c683 Compare March 16, 2021 18:14
@mileo
Copy link
Member Author

mileo commented Mar 16, 2021

@marcelsavegnago agora foi.

rvalyi
rvalyi approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcelsavegnago
marcelsavegnago approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mileo
Copy link
Member Author

mileo commented Mar 16, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1030-by-mileo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2112b20 into OCA:12.0 Mar 16, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fb0f288. Thanks a lot for contributing to OCA. ❤️

@mileo mileo deleted the feature/cnab-statement-import branch March 16, 2021 21:33
@mileo mileo mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@rvalyi rvalyi rvalyi approved these changes

@renatonlima renatonlima Awaiting requested review from renatonlima

@jcarvalhido jcarvalhido Awaiting requested review from jcarvalhido

Assignees
No one assigned
Labels
12.0 approved merged 🎉 needs review new feature ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mileo @rvalyi @marcelsavegnago @OCA-git-bot