Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP]l10n_it_riba: improvements for is_past_due field #4536

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

matteonext
Copy link
Contributor

@matteonext matteonext commented Jan 17, 2025

  • Changed placement to see the label better
  • When a invoice is duplicated the field is set to false. This behavior that was not present before this commit
    RiBa: is_unsolved field fixes #4460

@matteonext matteonext force-pushed the 16.0-imp-l10n_it_riba branch from bb015d2 to de4650e Compare January 17, 2025 09:07
@primes2h
Copy link
Contributor

primes2h commented Jan 17, 2025

Nel titolo andrebbe messo il nome del campo coinvolto, che nella 16.0 è cambiato.
Nella descrizione puoi aggiungere anche il riferimento alla issue collegata?

@francesco-ooops francesco-ooops linked an issue Jan 17, 2025 that may be closed by this pull request
2 tasks
@primes2h
Copy link
Contributor

@matteonext
Manca la correzione del titolo della PR.

  1. l10n_it_ricevute_bancarie → l10n_it_riba
  2. is_unsolved → is_past_due

@matteonext matteonext changed the title [IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field [IMP]l10n_it_riba: improvements for is_past_due field Jan 17, 2025
@matteonext matteonext changed the title [IMP]l10n_it_riba: improvements for is_past_due field [16.0][IMP]l10n_it_riba: improvements for is_past_due field Jan 17, 2025
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteonext
Dimenticavo, allo stesso modo va rinominato il commit mettendo il nome corretto del modulo v.16.0.
Poi ci siamo.

- Changed placement to see the label better
- When a invoice is duplicated the field is set to
  false. This behavior that was not present
  before this commit
@matteonext matteonext force-pushed the 16.0-imp-l10n_it_riba branch from de4650e to 7e4e612 Compare January 20, 2025 08:18
@matteonext
Copy link
Contributor Author

@primes2h Grazie per la review. Dovrei aver concluso le modifiche richieste.

@matteonext matteonext requested a review from primes2h January 20, 2025 08:19
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review tecnica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RiBa: is_unsolved field fixes
3 participants