[16.0][FIX] l10n_es_aeat_sii_oca: Avoid invoice copy with type change in tests #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a new integrity check for avoiding inconsistent states. We were using a trick on tests for quickly copying a customer invoice, and converting the copy to vendor bill, but data got inconsistent doing it. For what we were testing, that was not a problem, but with the new check, the operation is aborted. Thus, we create the vendor bill from scratch, refactoring a method for doing it easily. We also take the occasion to improve a bit the number of invoice copies done.
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c827782. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new integrity check for avoiding inconsistent states. We were using a trick on tests for quickly copying a customer invoice, and converting the copy to vendor bill, but data got inconsistent doing it.
For what we were testing, that was not a problem, but with the new check, the operation is aborted.
Thus, we create the vendor bill from scratch, refactoring a method for doing it easily.
We also take the occasion to improve a bit the number of invoice copies done.
@Tecnativa