Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] payment_redsys: Migration to 17.0 #3511

Merged
merged 52 commits into from
Jun 12, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 4, 2024

Module migrated to version 17.0

cc https://github.com/APSL 148570

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Issue #3298

sergio-teruel and others added 30 commits April 4, 2024 12:42
* Corregido error en caso de que refence no este
  informado, al renderizar la plantilla del boton de pago.
* Corregido error que no permite pagar por transferencia al instalar
  el modulo payment_redsys
* Añadidas descripciones de los productos de la cesta a la clave 'DS_Merchant_ProductDescription'.
* Make quotation sending optional
  when a transaction ends without error website_sale module already sends an e-mail with the confirmed order, so it May not be necessary to send another e-mail with the same order unconfirmed.
* Add more Redsys frontend languages
* Remove options tab
* Send quotation e-mail invoking force_quotation_send() instead of action_quotation_send() + send_mail()

  * The function send_mail() does not respect the context language so the email is always sent in English.
  * It's not necessary to create the function send_mail() to sent an email when exists the method force_quotation_send().

* Add detailed error info
…r payment + Default values for urk_KO and url_OK + option to print print sale report. Delete url_ok and url_ko fields + Redondeo de merchant_amount
The discount is shown on the order summary if the current user is a member of sale.group_discount_per_so_line group

OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
[IMP] payment_redsys: Allow partial payment by percent
Includes to allow show order for unauthenticated users
When we have an order sequence of length six (SO123456), the signature process fails with the following message:

Server Error:
We are not able to redirect you to the payment form. 'str' object has no attribute 'decode'
Currently translated at 71.6% (48 of 67 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/

Translated using Weblate (Spanish)

Currently translated at 100.0% (67 of 67 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/

Translated using Weblate (Spanish)

Currently translated at 100.0% (67 of 67 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/
Currently translated at 100.0% (47 of 47 strings)

Translation: l10n-spain-13.0/l10n-spain-13.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-payment_redsys/es/
Currently translated at 97.9% (46 of 47 strings)

Translation: l10n-spain-13.0/l10n-spain-13.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-payment_redsys/ca/
…jecutar post procesado al recibir el formulario POST de Redsys + Avoid execute method por non Redsys acquirer
Currently translated at 100.0% (46 of 46 strings)

Translation: l10n-spain-14.0/l10n-spain-14.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-payment_redsys/ca/
weblate and others added 5 commits April 4, 2024 12:42
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-16.0/l10n-spain-16.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-payment_redsys/
Currently translated at 100.0% (45 of 45 strings)

Translation: l10n-spain-16.0/l10n-spain-16.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-payment_redsys/es/
`_get_default_payment_method_id` has an extra argument: "code".
@peluko00 peluko00 mentioned this pull request Apr 4, 2024
47 tasks
@FernandoRomera
Copy link
Contributor

@peluko00
remove files of modelo 347

@peluko00
Copy link
Contributor Author

peluko00 commented Apr 5, 2024

@peluko00 remove files of modelo 347

Fix it! Test test_l10n_es_aeat_mod303 of module l10n_es_aeat_mod303 failed. Any idea?

@HaraldPanten
Copy link
Contributor

/ocabot migration payment_redsys

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 11, 2024
Copy link
Contributor

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good, checked in runboat

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, tested on the Runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Este PR contiene cambios en archivos del 347 en el penúltimo commit que luego se vuelve a deshacer en el último. Eso no es correcto.

@peluko00
Copy link
Contributor Author

Este PR contiene cambios en archivos del 347 en el penúltimo commit que luego se vuelve a deshacer en el último. Eso no es correcto.

Corregido, gracias Pedro!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3511-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b1b832d into OCA:17.0 Jun 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e1a3977. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.