[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

manuelregidor · 2024-09-27T06:34:04Z

Supersedes: #3504

En esta migración se han incluido algunos cambios con respecto a v16:

Se ha eliminado la dependencia hacia el módulo queue_job. Ahora, el envío al SII se realiza a través de triggers, una opción base de Odoo.
Se han incluido las funcionalidades del módulo l10n_es_dua_sii (https://github.com/OCA/l10n-spain/tree/16.0/l10n_es_dua_sii), que en v17 ya no será necesario por haber pasado la gestión del DUA al módulo l10n-es.
Se ha eliminado el envío instantáneo cuando se valida una factura.

Quedará pendiente crear un nuevo campo sii_start_date en res.company, que serviría para que la función _compute_sii_enabled de sii.mixin lo tenga en cuenta para dar valor al campo sii_enabled.

T-5833

manuelregidor · 2024-09-27T06:41:30Z

@HaraldPanten @ValentinVinagre

HaraldPanten

Un par de comentarios, antes de revisarlo funcionalmente:

En el README (apartado DESCRIPTION) se sigue haciendo referencia al queue_job. Ese punto habría que quitarlo.
Puedes poner a Sygel como autores? Hemos hecho un buen refactoring y creo que es justo estar ahí. @pedrobaeza entiendo que no hay problema en ello, no?

Gracias!

pedrobaeza · 2024-09-27T06:59:27Z

Estoy de acuerdo con la co-autoría en este caso. Bien es cierto que AuresTIC (cc @zamberjo) por trabajos pasados también la merece.

manuelregidor · 2024-09-27T07:50:15Z

@HaraldPanten Cambios aplicados. En cuanto a los autores, he añadido a Sygel. Si finalmente tengo que añadir a AuresTIC, lo hago en un momento.

pedrobaeza · 2024-09-27T07:54:45Z

Incluid por favor #3736

manuelregidor · 2024-09-27T07:59:40Z

@pedrobaeza incluido

pedrobaeza · 2024-09-28T08:50:42Z

/ocabot migration l10n_es_aeat_sii_oca

Habría que incluir (adaptando) #3740 para los nuevos impuestos de octubre.

pedrobaeza · 2024-09-28T20:45:00Z

Para incluir también #3741, y se pueden juntar ambos commits, ya que es un leftover del primero.

manuelregidor · 2024-09-30T06:35:07Z

@pedrobaeza commits añadidos

pedrobaeza · 2024-10-09T10:51:54Z

Incluye por favor #3759, y a ver si esta semana lo puedo revisar ya para fusionarlo.

manuelregidor · 2024-10-09T13:33:31Z

@pedrobaeza commit #3759 añadido

Jesarregui

Functional Review: LGTM

HaraldPanten

Seems to be OK.

HaraldPanten

Disculpad, para el SII vamos a añadir la compatibilidad con DUA (impuestos que ya llevan en el core) en este mismo módulo, no me acordaba.

Queda este aspecto pendiente.

Jesarregui

Functional Review: LGTM

manuelregidor · 2024-11-06T08:02:45Z

@pedrobaeza @etobella @acysos Ya se puede revisar.

Since several days ago, the agency is returning tiemout when trying to connect to it. It's not happening for all the hosts, but GitHub is affected. The only solution for now is to disable the connection tests. We also remove the old Gipuzkoa agency. Fixes OCA#3589

It seems they are working regularly again.

Some others modules call reversal but active_ids is not an account.move: module OE helpdesk_account (from a helpdesk ticket, we can create a "Refund")

…er method Since odoo/odoo@07be14e3086f473ed9a8c4b12ea7c, Odoo has a helper method in AccountTestInvoicingCommon called `_create_invoice`. There are some tests here in this repository using the same name for methods with the decorator `classmethod` and also inheriting from the previous one, so they collide. - l10n_es_aeat_sii_oca: l10n_es_pos_sii adds the inheritance on AccountTestInvoicingCommon - l10n_es_intrastat_report: Direct inheritance. The solution is to rename these methods to another name.

Steps to reproduce: - Enable SII in a company with connector with a delay of 48 hours. - Create and validate an invoice. A job is configured for being executed in 48 hours. - Next day, filter "Not sent to SII", and do Action > Send to SII. Result: the pending invoices are requeued and the delay is reapplied, so the invoices will be sent in 48 hours from that moment. Doing this indefinitely, the invoices will never be sent! Although it's a weird behavior, let's avoid it not requeuing the invoices with pending jobs. For this, a little refactor in the code has been done, not calling _cancel_sii_jobs, but filtering another way, and not removing previous failed jobs, which can be considered the only functional change, and it's not bad IMO. TT50641

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

Creación de un nuevo modelo en `l10n_es_aeat` llamado *aeat_mixin*, del que heredan *sii.mixin* (ya existente) y un nuevo *verifactu.mixin*. Refactor de *sii.mixin* pasando funcionalidad a *aeat_mixin* Se han renombrado varios campos sii_* a aeat_* ya que serán utilizados por ambos.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

Following odoo/odoo@fbc7214, this commit puts the new taxes on the corresponding SII maps for being able to send invoices containing them to the AEAT service. TT51016

Similar to OCA#3744 TT51159

…atibilities (hr_expense for example) Steps to reproduce: - Install hr_expense - Create a purchase type journal named Expenses and uncheck the Enable SII field. - Go to Expense > Configuration > Settings and define in Employee Expense Journal the Expenses journal previously created - Create an expense and an expense sheet - Click on the Submit to manager button - Click on the Approve button - Click on the Post journal entries button - The journal entry will be created correctly without any error TT51825

…abled field TT52143

ValentinVinagre

Algunos comentarios. Por otro lado, sería interesante ir guardando los triggers realizados para el sii? se podría modificar la función de _gc_cron_triggers
https://github.com/odoo/odoo/blob/e957e9bbc6ac68e8a89be4f6fbc46928adb24584/odoo/addons/base/models/ir_cron.py#L554

ValentinVinagre · 2025-02-14T09:40:43Z

l10n_es_aeat_sii_oca/data/aeat_sii_tax_agency_data.xml

@@ -96,6 +96,52 @@
            name="sii_wsdl_ps_test_address"
        >https://sii-prep.egoitza.gipuzkoa.eus/JBS/HACI/SSII-FACT/ws/fr/SiiFactPAGV1SOAP</field>
    </record>
+    <!-- TODO: remove?-->
+    <record id="aeat_sii_tax_agency_gipuzkoa_1_0" model="aeat.tax.agency">


¿Vale la pena mantener las conexiones antiguas?

Quizás se puedan eliminar ya, solo que me tendrían que confirmar cuáles son las que ya no van a ser necesarias.

l10n_es_aeat_sii_oca/models/sii_mixin.py

l10n_es_aeat_sii_oca/models/account_move.py

l10n_es_aeat_sii_oca/data/l10n.es.aeat.map.tax.line.tax.csv

l10n_es_aeat_sii_oca/data/ir_cron.xml

l10n_es_aeat_sii_oca/models/sii_mixin.py

l10n_es_aeat_sii_oca/readme/CONFIGURE.md

ValentinVinagre · 2025-02-14T12:02:50Z

l10n_es_aeat_sii_oca/wizards/account_move_reversal.py

@@ -37,7 +37,7 @@ def default_get(self, fields_list):
        if (
            "sii_refund_type" in fields_list
            or "sii_refund_type_required" in fields_list
-        ) and self.env.context.get("active_model") == "account.move":
+        ):
            invoices = self.env["account.move"].browse(


en vez de un browse, se podría realizar un search y ampliar el dominio para que ya devuelva directamente las facturas de tipo "in_invoice", "out_invoice", debido a que después no se vuelve a utilizar "invoices".
supplier_invoices.mapped("company_id.sii_enabled") --> No habría que revisar también el diario etc?

l10n_es_aeat_sii_oca/wizards/account_move_send_sii.py

manuelregidor · 2025-02-17T09:09:30Z

@ValentinVinagre Con respecto a la pregunta sobre si sería interesante ir guardando los triggers realizados para el sii, te comento. Por como funcionan los triggers, yo creo que no vale la pena. El trigger lo que hace es lanzar una planificada que puede que realice el envío de varias facturas al SII (es decir, el resultado del trigger no es el envío de una factura en concreto sino de todas aquellas que están pendientes de enviar). Con los jobs sí que cada job se encargaba del envío de una sola factura, pero con los triggers esto ha cambiado.

HaraldPanten reviewed Sep 27, 2024

View reviewed changes

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 1fb8cbf to 7c0456a Compare September 27, 2024 07:49

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 7c0456a to fc0ea1f Compare September 27, 2024 07:58

OCA-git-bot added this to the 17.0 milestone Sep 28, 2024

OCA-git-bot mentioned this pull request Sep 28, 2024

Migration to version 17.0 #3298

Open

49 tasks

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch 2 times, most recently from ef7a702 to 7455920 Compare September 30, 2024 06:27

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 7455920 to 6511e98 Compare October 9, 2024 13:24

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 6511e98 to 69e97db Compare October 21, 2024 05:49

Jesarregui approved these changes Oct 22, 2024

View reviewed changes

HaraldPanten approved these changes Oct 22, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 22, 2024

HaraldPanten requested changes Oct 23, 2024

View reviewed changes

OCA-git-bot removed the approved label Oct 23, 2024

HaraldPanten self-requested a review October 30, 2024 14:34

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch 3 times, most recently from 82c6319 to 2467f8e Compare November 4, 2024 17:08

Jesarregui approved these changes Nov 6, 2024

View reviewed changes

pedrobaeza and others added 22 commits February 13, 2025 14:21

[BOT] post-merge updates

4a9b8fa

[IMP] l10n_es_aeat_sii_oca: Reactivate agencies tests

8f2c869

It seems they are working regularly again.

[BOT] post-merge updates

754e1f3

[FIX] l10n_es_aeat_sii_oca: check coming from move

f07872c

Some others modules call reversal but active_ids is not an account.move: module OE helpdesk_account (from a helpdesk ticket, we can create a "Refund")

[BOT] post-merge updates

a3d360c

[BOT] post-merge updates

a4fdc42

[UPD] Update l10n_es_aeat_sii_oca.pot

4cad501

[BOT] post-merge updates

4d843ad

Update translation files

41c6073

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

[UPD] Update l10n_es_aeat_sii_oca.pot

9cdbb85

[BOT] post-merge updates

d49fcb4

Update translation files

dad6450

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

[IMP] l10n_es_aeat_sii_oca: send with quarters only for voluntary

0ebb88d

[IMP] l10n_es_aeat_sii_oca: Updated taxes october 2024

816ee49

Following odoo/odoo@fbc7214, this commit puts the new taxes on the corresponding SII maps for being able to send invoices containing them to the AEAT service. TT51016

[FIX] l10n_es_aeat_sii_oca: Take into account inactive tax templates

dc9bbdb

Similar to OCA#3744 TT51159

[IMP] l10n_es_aeat_sii_oca: Improve SII not sent filter to use sii_en…

9cd6826

…abled field TT52143

[IMP] l10n_es_aeat_sii_oca: black, isort, prettier

6467a7f

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 6fd6212 to 1e33ea0 Compare February 13, 2025 13:33

ValentinVinagre reviewed Feb 14, 2025

View reviewed changes

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch 2 times, most recently from 8a6ad61 to 9e04655 Compare February 18, 2025 08:00

manuelregidor added 2 commits February 20, 2025 17:11

[MIG]l10n_es_aeat_sii_oca: Migration to 17.0

8f6de46

[IMP]l10n_es_aeat_sii_oca: sii con DUA

96cda40

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 9e04655 to 96cda40 Compare February 20, 2025 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

manuelregidor commented Sep 27, 2024 •

edited

Loading

manuelregidor commented Sep 27, 2024

HaraldPanten left a comment

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 28, 2024

pedrobaeza commented Sep 28, 2024

manuelregidor commented Sep 30, 2024

pedrobaeza commented Oct 9, 2024

manuelregidor commented Oct 9, 2024

Jesarregui left a comment

HaraldPanten left a comment

HaraldPanten left a comment

Jesarregui left a comment

manuelregidor commented Nov 6, 2024

ValentinVinagre left a comment •

edited

Loading

ValentinVinagre Feb 14, 2025

manuelregidor Feb 17, 2025

ValentinVinagre Feb 14, 2025

manuelregidor commented Feb 17, 2025

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

Are you sure you want to change the base?

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

Conversation

manuelregidor commented Sep 27, 2024 • edited Loading

manuelregidor commented Sep 27, 2024

HaraldPanten left a comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 28, 2024

pedrobaeza commented Sep 28, 2024

manuelregidor commented Sep 30, 2024

pedrobaeza commented Oct 9, 2024

manuelregidor commented Oct 9, 2024

Jesarregui left a comment

Choose a reason for hiding this comment

HaraldPanten left a comment

Choose a reason for hiding this comment

HaraldPanten left a comment

Choose a reason for hiding this comment

Jesarregui left a comment

Choose a reason for hiding this comment

manuelregidor commented Nov 6, 2024

ValentinVinagre left a comment • edited Loading

Choose a reason for hiding this comment

ValentinVinagre Feb 14, 2025

Choose a reason for hiding this comment

manuelregidor Feb 17, 2025

Choose a reason for hiding this comment

ValentinVinagre Feb 14, 2025

Choose a reason for hiding this comment

manuelregidor commented Feb 17, 2025

manuelregidor commented Sep 27, 2024 •

edited

Loading

ValentinVinagre left a comment •

edited

Loading