Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] mail_template_substitute: Migration to 18.0 #39

Open
wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] mail_template_substitute: Migration to 18.0 #39

wants to merge 2 commits into from

Conversation

youelEl
Copy link

@youelEl youelEl commented Feb 27, 2025

No description provided.

@youelEl youelEl mentioned this pull request Feb 27, 2025
Open
@pedrobaeza pedrobaeza changed the title 18.0 mig mail template substitute [18.0][MIG] mail_template_substitute: Migration to 18.0 Feb 27, 2025
@pedrobaeza
Copy link
Member

Thanks for the the PR.

I have modified the PR title to match the expected one. You have to do the git fetch command crossing both repositories, for not losing the commit history.

mpascuall
mpascuall approved these changes Mar 14, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the git fetch to have all the commits and it LGTM, tested in runboat

peluko00
peluko00 approved these changes Mar 14, 2025
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when fetch commits

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 approved these changes

@mpascuall mpascuall mpascuall approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@youelEl @pedrobaeza @OCA-git-bot @peluko00 @mpascuall