[17.0][IMP] Added operating units group filter for PoS Orders Report #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BT-rmartin
suggested changes
Jan 3, 2025
pos_operating_unit/README.rst
Outdated
| @@ -77,6 +77,7 @@ Contributors | |||
| - Ooops404 <https://ooops404.com> | |||
|
|
|||
| - Ilyas <[email protected]> | |||
| - Daniel Herreros <[email protected]> | |||
There was a problem hiding this comment.
Move it out of Oooops404. You belong to a different company
| @@ -1,2 +1,3 @@ | |||
| - Ooops404 \<<https://ooops404.com>\> | |||
| - Ilyas \<<[email protected]>\> | |||
| - Daniel Herreros \<<[email protected]>\> | |||
There was a problem hiding this comment.
Move it out of Oooops404. You belong to a different company
| @@ -0,0 +1,3 @@ | |||
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | |||
There was a problem hiding this comment.
I would remove this header. The other files don't contain it
| @@ -0,0 +1,15 @@ | |||
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | |||
There was a problem hiding this comment.
I would remove this header. The other files don't contain it
There was a problem hiding this comment.
Yeap, this header is probably copy pasted from upstream odoo/odoo code.
Could you remove it?
BT-dherreros
force-pushed
the
17.0-imp-pos-operating-unit
branch
from
3c419e9 to
32e869e
Compare
BT-dmoreno
approved these changes
Jan 7, 2025
|
@OCA/pos-maintainers could we get this merge? |
ivantodorovich
approved these changes
Feb 3, 2025
| @@ -0,0 +1,15 @@ | |||
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | |||
There was a problem hiding this comment.
Yeap, this header is probably copy pasted from upstream odoo/odoo code.
Could you remove it?
BT-dherreros
force-pushed
the
17.0-imp-pos-operating-unit
branch
from
32e869e to
ffc437e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a group by filter to PoS order report using operating units by reusing the relational table from pos.order