Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Remove UserWarning: Field res.partner.industry.display_name should be declared with recursive=True #1885

Merged
merged 1 commit into from
Nov 23, 2024
Merged

[FIX] Remove UserWarning: Field res.partner.industry.display_name should be declared with recursive=True #1885

merged 1 commit into from
Nov 23, 2024

Conversation

pfranck
Copy link

@pfranck pfranck commented Oct 31, 2024

Add display_name with recursive=True

@pfranck
Copy link
Author

pfranck commented Oct 31, 2024

I think that should also be backported to 16.0

rousseldenis
rousseldenis approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, seems fair as soon as we introduced the display_name computation that depends on parent.

flotho
flotho approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1885-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 35e1dbd into OCA:17.0 Nov 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 903d634. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pfranck @OCA-git-bot @pedrobaeza @flotho @rousseldenis