Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] pos_category_vertical_display: New module pos_category_vertical_display #1290

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Jan 30, 2025

This module aims to display the POS categories in vertical view when you scroll.

cc https://github.com/APSL 166283
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

Old version:

image

New version:

image

@peluko00 peluko00 force-pushed the 17.0-add-pos_category_display branch 2 times, most recently from 98ab8c5 to 736c33d Compare January 30, 2025 07:38
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peluko00. Thanks for sharing, for such module, could you add a printscreen in the description.md file, to explain what is the change ?

Note :

On runboat, I don't understand what is vertical. Could you elaborate ?
thanks !

image

@peluko00
Copy link
Author

Hi @peluko00. Thanks for sharing, for such module, could you add a printscreen in the description.md file, to explain what is the change ?

Note :

On runboat, I don't understand what is vertical. Could you elaborate ? thanks !

image

Thanks for the feedback @legalsylvain . Basically the current version the scroll of POS categories is horizontally and with this module is vertical.
I uploaded the two versions.

@peluko00 peluko00 force-pushed the 17.0-add-pos_category_display branch from 736c33d to 05280e2 Compare January 30, 2025 11:43
@peluko00 peluko00 requested a review from legalsylvain January 30, 2025 11:48
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peluko00 peluko00 force-pushed the 17.0-add-pos_category_display branch from 05280e2 to ca7dbe2 Compare January 31, 2025 14:10
@peluko00 peluko00 force-pushed the 17.0-add-pos_category_display branch from ca7dbe2 to 23880d1 Compare January 31, 2025 14:51
Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and runbot, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants