Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] product_packaging_type_vendor: Migration to 18.0 and renaming to product_packaging_level_vendor #1833

Open
wants to merge 6 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] product_packaging_type_vendor: Migration to 18.0 and renaming to product_packaging_level_vendor #1833

wants to merge 6 commits into from

Conversation

thienvh332
Copy link

Context:

  • product_packaging_type was renamed to product_packaging_level.

Changes:

  • Change product_packaging_type_vendor to product_packaging_level_vendor

Depends on:

@thienvh332 thienvh332 marked this pull request as ready for review January 6, 2025 11:15
@nilshamerlinck
Copy link

s/Change/Rename

depending PR has now been merged

@thienvh332 thienvh332 force-pushed the 18.0-mig-product_packaging_type_vendor branch from ac807d3 to 6632d83 Compare January 22, 2025 05:33
@thienvh332 thienvh332 changed the title [18.0][MIG] product_packaging_level_vendor: Migration to 18.0 [18.0][MIG] product_packaging_type_vendor: Migration to 18.0 and renaming to product_packaging_level_vendor Jan 22, 2025
TDu
TDu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

ajaniszewska-dev
ajaniszewska-dev approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

@TDu TDu TDu approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thienvh332 @nilshamerlinck @OCA-git-bot @TDu @ajaniszewska-dev @JuMiSanAr @mymage