[16.0][MIG] project_forecast_line #1247

ntsirintanis · 2024-03-06T15:01:21Z

No description provided.

dreispt

Please squash your fixup commits

github-actions · 2024-09-01T12:10:17Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

gjotten · 2024-09-04T09:24:21Z

@OCA/project-service-maintainers this needs a no-stale

alexey-pelykh

Code LGTM

in some cases, we could have capacity consumed by a task which was not matching a work capacity line in the period because of a faulty optimisation we were making which skipped the creation of lines with a capacity of 0 -> then we had no line on which to compute the negative consolidated capacity. We remove the optimisation to fix this case and show the problematic periods in the consolidated capacity graphs

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

During some operations, forecast lines are deleted and recreated. This can lead to some hr.employee.forecast.role lines being deleted which leaves the forecast lines on the same period without a related document to store the consolidated capacity. Normally that line is recreated shortly afterwards but the creation does not recompute the link between the parent-less lines and the new one. This patches forces the recomputation when new lines are created.

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

when running in multi company, sometimes the user making a change is not connected using the company of the record. In this case the default value for company_id on forecast.line will lead to a wrong forecast. we fix this by using the best company when updating the forecast (the employee's company for task assigned to employees or leaves, the sale line's company for sales forecast

the condition was wrong, preventing the fast update from being used when only the remaining time is updated

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

when using the quick update, we would get an inversion of the sign of the forecast because the ratio was negative

…le in hr.employee.public

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

…get_bokeh_chart OCA/project#1247 OCA/project#1265

tarteo

Looks good so far. I partly tested this, I'll continue next week

tarteo · 2024-11-15T15:37:02Z

project_forecast_line/views/project_task_views.xml

+        <field name="inherit_id" ref="project.view_task_form2" />
+        <field name="arch" type="xml">
+            <field name="parent_id" position="before">
+                <field name="forecast_role_id" />


This is outside the sheet of the form:

tarteo · 2024-11-19T12:57:46Z

project_forecast_line/models/project_task.py

+    _inherit = ["project.task", "forecast.line.mixin"]
+
+    forecast_role_id = fields.Many2one("forecast.role", ondelete="restrict")
+    forecast_date_planned_start = fields.Date("Planned start date")


Is it better to use existing fields from project_timeline?

tarteo · 2024-11-19T13:08:49Z

project_forecast_line/views/res_config_settings_views.xml

+                    class="app_settings_block"
+                    data-string="Forecast"
+                    string="Forecast"
+                    data-key="project_forecast_line"


This should be changed to forecast, or the action should be changed. Otherwise this happens:

tarteo · 2024-11-19T13:48:31Z

project_forecast_line/models/project_task.py

+            if not task._should_have_forecast():
+                task_with_lines_to_clean.append(task.id)
+                continue
+            if task.project_id.stage_id:


When updating tasks I get this error:

Because of

If I assign the group to the user I don't get it.

tarteo · 2024-11-19T13:51:15Z

project_forecast_line/demo/sale.xml

@@ -0,0 +1,85 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+        <record id="sale_order_software_project" model="sale.order">


nitpicking: Too much indentation

tarteo · 2024-11-19T14:02:38Z

@ntsirintanis Will you be working on this or can I continue the work?

ntsirintanis · 2024-11-19T14:05:30Z

@ntsirintanis Will you be working on this or can I continue the work?

Hi @tarteo

First of all thanks for your review, very very much appreciated. I will probably pick it up next week, but if you are in a hurry, please go ahead and push your commits.

tarteo · 2024-11-19T14:08:11Z

👍 Awesome thanks @ntsirintanis !!

ntsirintanis force-pushed the 16.0-mig-project_forecast_line branch from 7aa8f4a to 99855fc Compare March 6, 2024 15:24

ntsirintanis force-pushed the 16.0-mig-project_forecast_line branch from 99855fc to 549bdc6 Compare April 3, 2024 10:24

This was referenced Apr 15, 2024

[16.0][MIG] project_forecast_line_deadline #1264

Closed

[16.0][MIG] project_forecast_line_bokeh_chart #1265

Closed

dreispt requested changes Apr 27, 2024

View reviewed changes

ntsirintanis force-pushed the 16.0-mig-project_forecast_line branch from 7ffa1c0 to a5080b7 Compare April 29, 2024 07:13

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024

alexey-pelykh requested a review from dreispt September 4, 2024 10:00

alexey-pelykh approved these changes Sep 4, 2024

View reviewed changes

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024

yankinmax and others added 18 commits October 24, 2024 09:03

[15.0][ADD] project_forecast_line

2a1cf4e

[UPD] Update project_forecast_line.pot

1dc675e

[UPD] README.rst

7f7cc37

project_forecast_line: improve documentation

4ae91b9

[UPD] README.rst

c2e9fc8

project_forecast_line 15.0.1.0.1

035d235

project_forecast_line 15.0.1.0.2

faa6ad0

[15.0][FIX] project_forecast_line: take roles into account on calc

5879cc6

[15.0][IMP] project_forecast_line: setting to control consumption states

a525f23

bump version after clicking on merge by mistake

21f4fcf

[UPD] Update project_forecast_line.pot

b46f89a

Update translation files

a407e6e

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

[15.0][FIX] project_forecast_line: add missing access rights

c4540b0

[UPD] README.rst

d547b89

project_forecast_line 15.0.1.0.4

a98d1c1

project_forecast_line 15.0.1.0.5

65b936f

OCA-git-bot and others added 23 commits October 24, 2024 09:03

project_forecast_line 15.0.1.3.1

c435058

Added translation using Weblate (Italian)

ad403bb

Translated using Weblate (Italian)

2ef9d61

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

Translated using Weblate (Italian)

b28c31e

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

Translated using Weblate (Italian)

26ff6a1

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

Translated using Weblate (Italian)

3f33020

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

[FIX] wrong condition in task quick update

6f0022c

the condition was wrong, preventing the fast update from being used when only the remaining time is updated

[FIX] crash when a task is not related to a project

ce62111

fixup! [FIX] forecast_line: issue in multicompany

7fe5499

Translated using Weblate (Italian)

1cf70ec

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

[FIX] quick update sign inversion

fff5721

when using the quick update, we would get an inversion of the sign of the forecast because the ratio was negative

project_forecast_line 15.0.1.3.2

2bdbefa

[FIX] Fixed bug by adding hr.group_hr_user group to field not availab…

a48c4db

…le in hr.employee.public

project_forecast_line 15.0.1.3.3

bf61232

[UPD] README.rst

cac01ab

Added translation using Weblate (Spanish)

9f58850

Translated using Weblate (Spanish)

8055dda

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/es/

Update translation files

a8bc92b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

Translated using Weblate (Italian)

ef7a4fe

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

Translated using Weblate (Italian)

af065fc

Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/

[IMP] project_forecast_line: pre-commit stuff

412be4a

[MIG] project_forecast_line: Migration to 16.0

60e358f

ntsirintanis force-pushed the 16.0-mig-project_forecast_line branch from a5080b7 to 60e358f Compare October 24, 2024 07:04

tarteo added a commit to onesteinbv/addons-oca that referenced this pull request Nov 15, 2024

Add project_forecast_line, project_forecast_line_bokeh_chart, web_wid…

a567f2e

…get_bokeh_chart OCA/project#1247 OCA/project#1265

tarteo suggested changes Nov 15, 2024

View reviewed changes

tarteo suggested changes Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] project_forecast_line #1247

[16.0][MIG] project_forecast_line #1247

ntsirintanis commented Mar 6, 2024

dreispt left a comment

github-actions bot commented Sep 1, 2024

gjotten commented Sep 4, 2024

alexey-pelykh left a comment

tarteo left a comment

tarteo Nov 15, 2024

tarteo Nov 19, 2024

tarteo Nov 19, 2024

tarteo Nov 19, 2024

tarteo Nov 19, 2024

tarteo commented Nov 19, 2024

ntsirintanis commented Nov 19, 2024

tarteo commented Nov 19, 2024 •

edited

Loading

[16.0][MIG] project_forecast_line #1247

Are you sure you want to change the base?

[16.0][MIG] project_forecast_line #1247

Conversation

ntsirintanis commented Mar 6, 2024

dreispt left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 1, 2024

gjotten commented Sep 4, 2024

alexey-pelykh left a comment

Choose a reason for hiding this comment

tarteo left a comment

Choose a reason for hiding this comment

tarteo Nov 15, 2024

Choose a reason for hiding this comment

tarteo Nov 19, 2024

Choose a reason for hiding this comment

tarteo Nov 19, 2024

Choose a reason for hiding this comment

tarteo Nov 19, 2024

Choose a reason for hiding this comment

tarteo Nov 19, 2024

Choose a reason for hiding this comment

tarteo commented Nov 19, 2024

ntsirintanis commented Nov 19, 2024

tarteo commented Nov 19, 2024 • edited Loading

tarteo commented Nov 19, 2024 •

edited

Loading