[16.0][MIG] purchase_force_invoiced #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Eric @ Elico Corp <[email protected]>
Currently translated at 100.0% (4 of 4 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_force_invoiced/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_force_invoiced/
The purchase BI analysis is not taking into account the "Force invoiced" check for showing their quantity to be billed, so it gives contradictory information from the search filter and the pivot. This commit adapts the SQL report for taking this into account.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_force_invoiced/
…with inconsistent data
|
Tests are green, cool ! |
| ) | ||
| return product | ||
|
|
||
| def create_invoice_line(self, line, invoice): |
There was a problem hiding this comment.
Looks like you can remove this method now.
Set force_invoiced field invisible on RFQs (state not in purchase or done) force_invoiced is now tracked in chatter
alexis-via
force-pushed
the
16-mig_purchase_force_invoiced
branch
from
294b869
to
cd35dfd
Compare
|
@StefanRijnhart Could you update your review? |
StefanRijnhart
approved these changes
Feb 17, 2023
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f9db6fd. Thanks a lot for contributing to OCA. ❤️ |
|
next time link to migration issue please #1585 |
|
/ocabot migration purchase_force_invoiced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 small improvements: