[16.0][MIG] purchase_delivery_split_date: Migration to 16.0 #1687

FernandoRomera · 2022-12-19T10:55:50Z

No description provided.

Use v8 API Follow the OCA guidelines for manifest and README PEP8 Extend _create_stock_move because the method we used to extend in v7 doesn't exist anymore.

Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_delivery_split_date/zh_CN/

Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_delivery_split_date/pt_BR/

This changeset implements a missing part in the module description. If you have a purchase order with several lines, confirmed, then you change the dates on some of the line, this would be reflected in the related stock moves but not in the stock pickings which would not be split or merged by date.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_delivery_split_date/

Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_delivery_split_date/de/

rousseldenis · 2023-02-16T12:02:03Z

@FernandoRomera Some things seem weird to me.

I will do a PR on your branch soon.

rousseldenis · 2023-02-16T12:43:36Z

@gurneyalex Do you remember why you did this and why in this module (it seems functionally out of scope)?

b3e20e8

rousseldenis · 2023-02-16T18:37:02Z

@FernandoRomera I did this : MallorcaSoft#1

Changed test setup to classmethod
Fixed unused onchange to replaced compute method for date_planned field (see my previous comment)
Split one model per file

rousseldenis · 2023-02-16T18:54:39Z

I think I will also modify the code on purchase order as there are some operations that can be done by batch

rousseldenis · 2023-02-16T19:17:39Z

I think I will also modify the code on purchase order as there are some operations that can be done by batch

Done in PR mentionned above. I think that one is ready

… date_planned

FernandoRomera · 2023-02-17T08:57:55Z

@rousseldenis
Done.

rousseldenis · 2023-02-17T09:54:27Z

And functionally works as expected

bizzappdev · 2023-02-23T06:46:40Z

purchase_delivery_split_date/models/purchase_order_line.py

+            self.mapped("order_id")._check_split_pickings()
+        return res
+
+    def create(self, values):


@api.model_create_multi

lmignon · 2023-02-24T08:54:21Z

purchase_delivery_split_date/models/purchase_order_line.py

+    def create(self, values):
+        line = super().create(values)
+        if line.order_id.state == "purchase":
+            line.order_id._check_split_pickings()
+        return line


Suggested change

def create(self, values):

line = super().create(values)

if line.order_id.state == "purchase":

line.order_id._check_split_pickings()

return line

@api.model_create_multi

def create(self, vals_list):

lines = super().create(vals_list)

lines.order_id.filtered(lambda l: l.state == "purchase")._check_split_pickings()

return lines

gurneyalex · 2023-02-26T14:14:01Z

@gurneyalex Do you remember why you did this and why in this module (it seems functionally out of scope)?

b3e20e8

This does not seem to be out of scope to me.

Change 1:

consider this scenario:

User creates a PO, sets different dates on the lines and confirms -> you get different receptions based on the date lines.
User adds a line in the PO, saves -> I expect the delivery of the stock move to be done according to the date of the line and this was not done prior to the fix unless the line's planned date had been set / changed

Change 2:

scenario:

User creates a PO, sets dates on the PO lines, saves
User edits PO, changes quantity on one of the lines -> the lines planned date is reset as a side effect. This will cause frustration for the user as they will easily miss the date reset, or will be painfully aware of it and complain they need to put back the date to the original value after changing a quantity on a PO line. The change saves their time and sanity.

Please keep both in migrations of this module.

kimirondon · 2023-03-14T15:45:11Z

hello @FernandoRomera is this PR close to be merged?

vincent-cowboy · 2023-03-17T10:32:31Z

is the fix #1350 relevant to this PR?
also, there is a refactoring PR #1326 (linked to #1246)

andreampiovesana · 2023-03-17T14:13:35Z

merge?

dreispt · 2023-03-18T12:37:14Z

/ocabot merge nobump

OCA-git-bot · 2023-03-18T12:37:56Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1687-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2023-03-18T12:44:48Z

Congratulations, your PR was merged at 6d6a02a. Thanks a lot for contributing to OCA. ❤️

Lionel Sausin and others added 30 commits December 19, 2022 11:53

Module to split purchase receptions by dates

813c450

purchase_delivery_split_date

1276c31

Use v8 API Follow the OCA guidelines for manifest and README PEP8 Extend _create_stock_move because the method we used to extend in v7 doesn't exist anymore.

OCA Transbot updated translations from Transifex

1e41909

migration to v9

3d67e4d

OCA Transbot updated translations from Transifex

c44a9c3

Datetime issue.

2be0802

OCA Transbot updated translations from Transifex

54a7e36

[10.0][MIG] purchase_delivery_split_date

e25bac6

OCA Transbot updated translations from Transifex

145d7c4

[MIG][11.0] purchase_delivery_split_date

b7d965d

add new readme and travis fixes

8edef0a

[UPD] README.rst

ed68419

[UPD] Update purchase_delivery_split_date.pot

9cd6ec3

[MIG] purchase_delivery_split_date: Migration to v12

f7c775e

[UPD] Update purchase_delivery_split_date.pot

78a5cfa

[ADD] icon.png

97d07fc

[UPD] README.rst

3fe4793

Added translation using Weblate (Chinese (Simplified))

84dbf8f

[FIX] _get_group_keys(): date_planned is datetime

e1c5d15

purchase_delivery_split_date 12.0.1.0.1

68a5d1e

[UPD] Update purchase_delivery_split_date.pot

08d986e

[UPD] README.rst

5d3d201

[IMP] purchase_delivery_split_date: black, isort, prettier

406f459

[MIG] purchase_delivery_split_date: Migration to 13.0

5991aa5

[UPD] Update purchase_delivery_split_date.pot

eec9d42

FernandoRomera force-pushed the 16.0-mig-purchase_delivery_split_date branch 3 times, most recently from 3bc85c3 to 79a192b Compare February 8, 2023 15:28

[16.0][MIG] purchase_delivery_split_date: Migration to 16.0

210ffd0

FernandoRomera force-pushed the 16.0-mig-purchase_delivery_split_date branch from 79a192b to 210ffd0 Compare February 8, 2023 15:32

rousseldenis added 4 commits February 17, 2023 09:54

[IMP] purchase_delivery_split_date: Change tests setup to classmethod

4e9e836

[IMP] purchase_delivery_split_date: Reintroduce older fix to save the…

4454968

… date_planned

[IMP] purchase_delivery_split_date: Split one model per file

9366986

[IMP] purchase_delivery_split_date: Avoid too much queries

3865b04

rousseldenis approved these changes Feb 17, 2023

View reviewed changes

bizzappdev reviewed Feb 23, 2023

View reviewed changes

lmignon reviewed Feb 24, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 18, 2023

OCA-git-bot merged commit 4b7b5f6 into OCA:16.0 Mar 18, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] purchase_delivery_split_date: Migration to 16.0 #1687

[16.0][MIG] purchase_delivery_split_date: Migration to 16.0 #1687

FernandoRomera commented Dec 19, 2022

rousseldenis commented Feb 16, 2023

rousseldenis commented Feb 16, 2023

rousseldenis commented Feb 16, 2023 •

edited

Loading

rousseldenis commented Feb 16, 2023

rousseldenis commented Feb 16, 2023

FernandoRomera commented Feb 17, 2023

rousseldenis commented Feb 17, 2023

bizzappdev Feb 23, 2023

lmignon Feb 24, 2023 •

edited

Loading

gurneyalex commented Feb 26, 2023

kimirondon commented Mar 14, 2023

vincent-cowboy commented Mar 17, 2023

andreampiovesana commented Mar 17, 2023

dreispt commented Mar 18, 2023

OCA-git-bot commented Mar 18, 2023

OCA-git-bot commented Mar 18, 2023

[16.0][MIG] purchase_delivery_split_date: Migration to 16.0 #1687

[16.0][MIG] purchase_delivery_split_date: Migration to 16.0 #1687

Conversation

FernandoRomera commented Dec 19, 2022

rousseldenis commented Feb 16, 2023

rousseldenis commented Feb 16, 2023

rousseldenis commented Feb 16, 2023 • edited Loading

rousseldenis commented Feb 16, 2023

rousseldenis commented Feb 16, 2023

FernandoRomera commented Feb 17, 2023

rousseldenis commented Feb 17, 2023

bizzappdev Feb 23, 2023

Choose a reason for hiding this comment

lmignon Feb 24, 2023 • edited Loading

Choose a reason for hiding this comment

gurneyalex commented Feb 26, 2023

kimirondon commented Mar 14, 2023

vincent-cowboy commented Mar 17, 2023

andreampiovesana commented Mar 17, 2023

dreispt commented Mar 18, 2023

OCA-git-bot commented Mar 18, 2023

OCA-git-bot commented Mar 18, 2023

rousseldenis commented Feb 16, 2023 •

edited

Loading

lmignon Feb 24, 2023 •

edited

Loading