[15.0] [ENH] queue_job: identity_key enhancements #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-willdooit
commented
Jun 16, 2023
richard-willdooit
commented
- In production, a job which is waiting dependencies or which has started, but not completed, should not be repeated if the identity_key matches.
- In tests, the mock queue handler is now enhanced to allow better mimicking of the identity_key blocks from production.
- In tests, the mock queue handler now clears the enqueued jobs after performing them, to better reproduce what a production environment would do.
1. In production, a job which is waiting dependencies or which has started, but not completed, should not be repeated if the identity_key matches. 2. In tests, the mock queue handler is now enhanced to allow better mimicking of the identity_key blocks from production. 3. In tests, the mock queue handler now clears the enqueued jobs after performing them, to better reproduce what a production environment would do.
|
Hi @guewen, |
abhinavvaidya-tsd
approved these changes
Aug 9, 2023
Comment on lines
+260
to
+262
| patcher = mock.patch.object(job, "store") | ||
| self._store_patchers.append(patcher) | ||
| patcher.start() |
There was a problem hiding this comment.
Suggested change
with mock.patch.object(job, "store") as patcher:
self._store_patchers.append(patcher)Context Manager: Used the with statement to create a context for the mock patcher. This ensures that the patcher's cleanup (stop()) is automatically handled even if an exception occurs.
By using the with statement, you ensure that the patcher is properly started and stopped, avoiding potential issues with resource leaks or incorrect mocking behavior.
|
changes to be backported from #587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.