Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context #682

Open
wants to merge 4 commits into
base: 12.0
Choose a base branch
from
Open

[12.0][BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context #682

wants to merge 4 commits into from

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Sep 9, 2024 •
edited
Loading

@simahawk @rousseldenis
queue_job: unify no delay option
5c351fd 
Current situation:

* multiple keys for no good reason
* half baked: not all of them used everywhere
* no centralization
* poor naming

With this change we'll have:

* 1 and only one key to disable via ctx: ``queue_job__no_delay``
* 1 and only one key to disable via os env: ``QUEUE_JOB__NO_DELAY``
* backward compatibility with deprecation for old keys
@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@guewen @rousseldenis
Reorganize models and views in different files
7c1064f 
Split one model per file, as advised in the contribution guide.
@rousseldenis rousseldenis force-pushed the oca-port-pr-680-from-14.0-to-12.0 branch from 8859896 to 77d6da1 Compare September 10, 2024 08:11
@rousseldenis rousseldenis force-pushed the oca-port-pr-680-from-14.0-to-12.0 branch from 77d6da1 to 165508c Compare September 10, 2024 08:15
@rousseldenis rousseldenis changed the title [BCK] queue_job: unify no delay option [BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context Sep 10, 2024
@rousseldenis rousseldenis changed the title [BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context [12.0][BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context Sep 10, 2024
@rousseldenis
[IMP] queue_job: Don't raise a warning for valid context
f328bde 
As the 'queue_job__no_delay' context key is the valid one to use,
don't raise warnings during tests, but log it as information level.
@rousseldenis rousseldenis force-pushed the oca-port-pr-680-from-14.0-to-12.0 branch from c88ac06 to f328bde Compare September 10, 2024 08:29
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@hparfr hparfr hparfr approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rousseldenis @OCA-git-bot @gurneyalex @hparfr @FrancoMaxime @simahawk @guewen