Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] queue_job_cron: Migration to 18.0 #693

Merged
merged 50 commits into from
Oct 18, 2024
Merged

[18.0][MIG] queue_job_cron: Migration to 18.0 #693

merged 50 commits into from
Oct 18, 2024

Conversation

thienvh332
Copy link
Contributor

@thienvh332 thienvh332 commented Oct 7, 2024 •
edited by simahawk
Loading

@simahawk
Copy link
Contributor

simahawk commented Oct 7, 2024

/ocabot migration queue_job_cron

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 7, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 7, 2024
Open
5 tasks
simahawk
simahawk reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

mmequignon
mmequignon approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Queue job is merged in 18.0, can you please drop test-requirements ?

Cédric Pigeon and others added 25 commits October 16, 2024 10:20
@thienvh332
[ADD] add new module to execute ir_cron as queue_job
a1f2c73
@thienvh332
Improve tests coverage
e8cc40d
@sbidoul @thienvh332
queue_job_cron: do not require read access to ir.cron
1d56c00
@sbidoul @thienvh332
queue_job_cron: bump version
71a6b6d
@ThomasBinsfeld @thienvh332
[MIG] Queue Job Cron to 12.0
4c3a230
@oca-travis @thienvh332
[UPD] Update queue_job_cron.pot
787d93b
@OCA-git-bot @thienvh332
[ADD] icon.png
4d73ed2
@marylla @thienvh332
Added translation using Weblate (German)
3f59ede
@marylla @thienvh332
Translated using Weblate (German)
77f1d39 
Currently translated at 100.0% (4 of 4 strings)

Translation: queue-12.0/queue-12.0-queue_job_cron
Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_cron/de/
@liweijie0812 @thienvh332
Added translation using Weblate (Chinese (Simplified))
339f8db
@liweijie0812 @thienvh332
Translated using Weblate (Chinese (Simplified))
c4937b8 
Currently translated at 100.0% (4 of 4 strings)

Translation: queue-12.0/queue-12.0-queue_job_cron
Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_cron/zh_Hans/
@OCA-git-bot @thienvh332
[UPD] README.rst
497c4f6
@liweijie0812 @thienvh332
Rename Chinese translation files
d172e1c
@guewen @thienvh332
Set modules as uninstallable
7ef5fdd
@guewen @thienvh332
Migrate queue_job_cron to 13.0
c654c61
@guewen @thienvh332
Run pre-commit with black, isort, ...
7e7ad0f
@oca-travis @thienvh332
[UPD] Update queue_job_cron.pot
951683e
@OCA-git-bot @thienvh332
[UPD] README.rst
05ccae5
@OCA-git-bot @thienvh332
pre-commit update
3ddafeb
@guewen @thienvh332
queue_job_cron: remove @job decorator
3e363eb
@OCA-git-bot @thienvh332
queue_job_cron 13.0.2.0.0
ae541d9
@guewen @thienvh332
Fix channel name in jobs delayed for crons
d374df9 
The channel must be 'root.ir_cron', not 'ir_cron'.
@OCA-git-bot @thienvh332
queue_job_cron 13.0.2.1.0
db9036c
@sebastienbeau @thienvh332
[MIG] init V14 repo
4898be7 
- set module uninstallable
- add new .dot file config for v14
@sebastienbeau @thienvh332
[IMP] : black, isort, prettier
b88aaa6
sbidoul and others added 17 commits October 16, 2024 10:20
@sbidoul @thienvh332
Initialize 16.0
2aed254
@JoanMForgeFlow @thienvh332
[MIG][15.0] queue_job_cron to version 15.0
92180c5
@baimont @thienvh332
[MIG] queue_job_cron: Migration to 16.0
7a092e4
@OCA-git-bot @thienvh332
[UPD] README.rst
e1b9a25
@kikopeiro @thienvh332
Added translation using Weblate (Spanish)
5f7f42d
@OCA-git-bot @thienvh332
[UPD] README.rst
394d6bc
@kikopeiro @thienvh332
Translated using Weblate (Spanish)
615b222 
Currently translated at 100.0% (4 of 4 strings)

Translation: queue-16.0/queue-16.0-queue_job_cron
Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-queue_job_cron/es/
@weblate @thienvh332
Update translation files
725eb3b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: queue-16.0/queue-16.0-queue_job_cron
Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-queue_job_cron/
@nguyenminhchien @thienvh332
[IMP] queue_job_cron: Pre-commit auto fixes
591c404
@nguyenminhchien @thienvh332
[MIG] queue_job_cron: Migration to 17.0
d7bcafd
@thienvh332
[UPD] Update queue_job_cron.pot
8afaa89
@OCA-git-bot @thienvh332
[BOT] post-merge updates
9659373
@mymage @thienvh332
Added translation using Weblate (Italian)
f8985af
@mymage @thienvh332
Translated using Weblate (Italian)
e7c4f49 
Currently translated at 100.0% (4 of 4 strings)

Translation: queue-17.0/queue-17.0-queue_job_cron
Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-queue_job_cron/it/
@LoisRForgeFlow @thienvh332
[13.0][FIX] queue_job_cron: channel_id must be storable.
04fa5a7 
Otherwise, you cannot use any channel other than default (
root.ir_cron)
@lmignon @thienvh332
[IMP] queue_job_cron: Avoid parallel run
97ed569 
By default, odoo never runs the same cron job in parallel. This commit uses the identity key mechanism to enforce this mechanism when a cron job is run as a queue job. This behaviour can be controlled by a new setting on the cron definition but is activated by default to keep the original behaviour
@QuocDuong1306 @thienvh332
[MIG] queue_job_cron: Migration to 18.0
34f6a00
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-693-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-693-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit aef86a1 into OCA:18.0 Oct 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at adc728e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmequignon mmequignon mmequignon approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.