-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] queue_job_cron: Migration to 18.0 #693
Conversation
/ocabot migration queue_job_cron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Queue job is merged in 18.0, can you please drop test-requirements ?
Currently translated at 100.0% (4 of 4 strings) Translation: queue-12.0/queue-12.0-queue_job_cron Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_cron/de/
Currently translated at 100.0% (4 of 4 strings) Translation: queue-12.0/queue-12.0-queue_job_cron Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_cron/zh_Hans/
The channel must be 'root.ir_cron', not 'ir_cron'.
- set module uninstallable - add new .dot file config for v14
Currently translated at 100.0% (4 of 4 strings) Translation: queue-16.0/queue-16.0-queue_job_cron Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-queue_job_cron/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-16.0/queue-16.0-queue_job_cron Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-queue_job_cron/
Currently translated at 100.0% (4 of 4 strings) Translation: queue-17.0/queue-17.0-queue_job_cron Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-queue_job_cron/it/
Otherwise, you cannot use any channel other than default ( root.ir_cron)
By default, odoo never runs the same cron job in parallel. This commit uses the identity key mechanism to enforce this mechanism when a cron job is run as a queue job. This behaviour can be controlled by a new setting on the cron definition but is activated by default to keep the original behaviour
a434adf
to
34f6a00
Compare
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-693-by-simahawk-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
This PR has the |
Congratulations, your PR was merged at adc728e. Thanks a lot for contributing to OCA. ❤️ |
Ported PRs