[16.0][FIX] sale_channel_search_engine: Add to index #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen #16
This is unnecessary to call
_add_to_index()
if we don't find indexes where the records should be added to.This has a side effect:
_add_to_index()
returns the bindings of the record, if noindexes
is passed as argument to_add_to_index()
, it does so for all the indexes.Now imagine:
Channel A
linked to an index,Channel B
not linked to any index.Channel A
.Channel A
=>_synchronize_channel_index()
is triggered on the product._add_to_index(None)
will be called forChannel B
=>_add_to_index(None)
will return all the bindings of the product, including the binding created by the link withChannel A
._add_to_index()
.