[FIX] sale_layout_category_hide_detail: Improve interoperability, hide discounted price too #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing this module alongside a custom module of our own we noticed it failed.
The cause of this was a few instances of the following:
Though these show foresight they also lack parentheses around the epxression, if applied to an element that already has a
t-if
this forms an illogical expression with erroneous results.e.g.
hide_discount and not current_section or current_section.show_line_amount
causes an Exception when
hide_discount
is False andcurrent_section
is None, I hope you can see why.Additionally, while fixing this I noticed there was a unit price displayed in the sale portal layout when a line is discounted, that wasn't being hidden when it should have been, an extra rule was added for that case.