Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale_layout_category_hide_detail: Improve interoperability, hide discounted price too #291

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

Sibert-Aerts
Copy link

Installing this module alongside a custom module of our own we noticed it failed.
The cause of this was a few instances of the following:

<attribute
    name="t-if"
    add="not current_section or current_section.show_line_amount"
    separator=" and "
 />

Though these show foresight they also lack parentheses around the epxression, if applied to an element that already has a t-if this forms an illogical expression with erroneous results.
e.g. hide_discount and not current_section or current_section.show_line_amount
causes an Exception when hide_discount is False and current_section is None, I hope you can see why.

Additionally, while fixing this I noticed there was a unit price displayed in the sale portal layout when a line is discounted, that wasn't being hidden when it should have been, an extra rule was added for that case.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants