[18.0][MIG] sale_commercial_partner: Migration to 18.0 #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, sale_order_import_ubl, sale_order_import_csv, sale_order_ubl, sale_commercial_partner
OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex
[UPD] Update sale_commercial_partner.pot
[UPD] README.rst [UPD] Update sale_commercial_partner.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_commercial_partner/ [UPD] README.rst
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_commercial_partner/zh_CN/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_commercial_partner/pt_BR/
[UPD] Update sale_commercial_partner.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_commercial_partner/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_commercial_partner/es/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_commercial_partner/
[UPD] Update sale_commercial_partner.pot
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_commercial_partner/nl/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_commercial_partner/ca/
Currently translated at 40.0% (2 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_commercial_partner/fr_FR/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_commercial_partner/fr/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_commercial_partner/de/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_commercial_partner/es_MX/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_commercial_partner/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_commercial_partner/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_commercial_partner/fr/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_commercial_partner Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_commercial_partner/it/
BertVGroenendael
force-pushed
the
18.0-mig-sale_commercial_partner
branch
2 times, most recently
from
2ed36c7 to
b691c55
Compare
BertVGroenendael
force-pushed
the
18.0-mig-sale_commercial_partner
branch
from
b691c55 to
6e0dad0
Compare
61 tasks
|
Pls squash odoo bot commit |
|
|
||
|
|
||
| class TestSaleCommercialPartner(common.TransactionCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
Thanks for adding the test! Can you refactor to use @classmethod setUpClass(cls)?
LucasTran380381
suggested changes
Dec 3, 2024
| <field name="commercial_partner_id" invisible="1" /> | ||
| </field> | ||
| </field> | ||
| </record> |
There was a problem hiding this comment.
recommend to removed ( not need to add invisible field)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
In odoo18, domain field will automatically added invisible field that mean no need to declared invisible field to use it in domain
There was a problem hiding this comment.
Excellent, thanks for clarifying! I tested this successfully, using the field in domain and invisible attributes. Found the implementation in odoo/odoo#137031. I'll add it to the OCA's 18.0 migration guidelines.
Just curious, do you know if this is documented anywhere?
There was a problem hiding this comment.
No documentation, recommend dev using odoo-module-migrator and follow guidelines.
This was referenced Dec 5, 2024
|
/ocabot migration sale_commercial_partner |
|
@BertVGroenendael Could you attend @StefanRijnhart comment ? |
|
Since this PR has been inactive for 2 weeks, I've started working on related PRs based on this approach |
|
Closing in favor of #3504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.