-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] sale_order_product_recommendation: Migration to 18.0 #3419
base: 18.0
Are you sure you want to change the base?
[MIG] sale_order_product_recommendation: Migration to 18.0 #3419
Conversation
This wizard that you can see now in your quotations will let you add products quickly based on the customer's recent purchase history.
We can't limit results on read_group, because we can't set the same criteria to order results, and thus the N groups populated might be not the top ones looked for.
- When a SO is confirmed the button is still visible so the wizard can be used to add or remove lines and products. The same restrictions that exist editing the order manually apply to the wizard.
Using force_save option in views
- Improve test declaration inherability
…ok products in recommendation wizard BTW I fixed a bug that counted products in the active SO as delivered, when it was impossible in most cases. Fixed the test to reflect the new logic. Co-Authored-By: Jairo Llopis <[email protected]>
Add kanban + form for proper mobile usage.
…fied` It's better to simply check the flag condition than to keep that field.
…t to product default one Having a related field to default sale secondary UoM makes this recommendator to not fit possible different secondary UoM to be used. This commit fixes this behavior. A refactoring on the main module having a prepare method hook has been needed.
…hanges Previous code was not very resilient to possible extra adaptations or require specific code to be added to the old hook `_trigger_so_line_onchanges`. With this, we make sure all onchanges are executed thanks to the odoo.tests.Form class. We lose a bit of performance, but it's better than to have issues with data not correctly synchronized.
For avoiding errors like accessing mail.tracking.value when changing values.
…ct.product model instead of product.template in wizard kanban view. TT26749
…from listprice or from last sale order. TT26727
…from listprice or from last sale order. Computed with ORM instead of sql queries TT26727
… line with last_sale_order price unit from recommendation line TT27183
…recommendation wizard always sort by times delivered desc (even if the sale order already has any line)
…orders by delivery address
Currently translated at 100.0% (72 of 72 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/es/
Before this patch, UoM wasn't being properly inherited into generated lines when those lines didn't exist previously in the SO. Also, changing it manually didn't work as expected in that same case. This is because the UoM was related to the SOL UoM. But if there was no SOL, it did nothing. Now it's properly computed. UoM comes from the product if there's no SOL or it can't provide it. The user can change it to other UoM of the same category. The change is propagated when applying the wizard, both when creating lines and updating them. Tests added. @moduon MT-4472
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
Currently translated at 100.0% (75 of 75 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/es/
Currently translated at 100.0% (75 of 75 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/it/
Product category was labeled as "Complete name" due to a typo in field definition, which didn't make any sense. @moduon MT-5404
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
…gating recommendations to sale order
Currently translated at 100.0% (73 of 73 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/pt_BR/
/ocabot migration sale_order_product_recommendation |
673880e
to
f60698c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Just fields changes
sale_order_product_recommendation/wizards/sale_order_recommendation.py
Outdated
Show resolved
Hide resolved
sale_order_product_recommendation/wizards/sale_order_recommendation.py
Outdated
Show resolved
Hide resolved
sale_order_product_recommendation/wizards/sale_order_recommendation.py
Outdated
Show resolved
Hide resolved
f60698c
to
6585d51
Compare
self.env["sale.order.line"] | ||
.sudo() | ||
.read_group( | ||
self._recommendable_sale_order_lines_domain(), | ||
["product_id", "qty_delivered"], | ||
["product_id"], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use _read_group
to improve performance
found_lines = sorted( | ||
found_lines, | ||
key=lambda res: (res["product_id_count"], res["qty_delivered"]), | ||
reverse=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be done on _read_group
No description provided.