Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] sale_order_product_recommendation: Migration to 18.0 #3419

Open
wants to merge 94 commits into
base: 18.0
Choose a base branch
from

Conversation

BT-mchechlacz
Copy link

No description provided.

yajo and others added 30 commits November 20, 2024 23:54
This wizard that you can see now in your quotations will let you add products quickly based on the customer's recent purchase history.
We can't limit results on read_group, because we can't set the same
criteria to order results, and thus the N groups populated might be
not the top ones looked for.
- When a SO is confirmed the button is still visible so the wizard can
be used to add or remove lines and products. The same restrictions that
exist editing the order manually apply to the wizard.
- Improve test declaration inherability
…ok products in recommendation wizard

BTW I fixed a bug that counted products in the active SO as delivered, when it was impossible in most cases. Fixed the test to reflect the new logic.

Co-Authored-By: Jairo Llopis <[email protected]>
Add kanban + form for proper mobile usage.
…fied`

It's better to simply check the flag condition than to keep that field.
…t to product default one

Having a related field to default sale secondary UoM makes this recommendator to not fit
possible different secondary UoM to be used.

This commit fixes this behavior. A refactoring on the main module having a prepare
method hook has been needed.
…hanges

Previous code was not very resilient to possible extra adaptations or require
specific code to be added to the old hook `_trigger_so_line_onchanges`.

With this, we make sure all onchanges are executed thanks to the odoo.tests.Form
class.

We lose a bit of performance, but it's better than to have issues with data not
correctly synchronized.
For avoiding errors like accessing mail.tracking.value when changing values.
…ct.product model instead of product.template in wizard kanban view.

TT26749
…from listprice or from last sale order.

TT26727
…from listprice or from last sale order. Computed with ORM instead of sql queries

TT26727
… line with last_sale_order price unit from recommendation line

TT27183
…recommendation wizard always sort by times delivered desc (even if the sale order already has any line)
mymage and others added 18 commits November 21, 2024 13:19
Currently translated at 100.0% (72 of 72 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/it/
Currently translated at 100.0% (72 of 72 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/es/
Before this patch, UoM wasn't being properly inherited into generated lines when those lines didn't exist previously in the SO.

Also, changing it manually didn't work as expected in that same case.

This is because the UoM was related to the SOL UoM. But if there was no SOL, it did nothing.

Now it's properly computed. UoM comes from the product if there's no SOL or it can't provide it. The user can change it to other UoM of the same category. The change is propagated when applying the wizard, both when creating lines and updating them. Tests added.

@moduon MT-4472
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
Currently translated at 100.0% (75 of 75 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/es/
Currently translated at 100.0% (75 of 75 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/it/
Product category was labeled as "Complete name" due to a typo in field definition, which didn't make any sense.

@moduon MT-5404
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
Currently translated at 100.0% (73 of 73 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/pt_BR/
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_product_recommendation

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 21, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 21, 2024
47 tasks
@BT-mchechlacz BT-mchechlacz force-pushed the 18.0-mig-sale_order_product_recommendation branch 4 times, most recently from 673880e to f60698c Compare November 25, 2024 09:54
Copy link

@BT-crodriguez BT-crodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just fields changes

@BT-mchechlacz BT-mchechlacz force-pushed the 18.0-mig-sale_order_product_recommendation branch from f60698c to 6585d51 Compare November 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.