[ADD] [16.0] sale_order_line_product_attribute_values #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcvalgar
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Functional review.
LGTM, thank you @Shide
OCA - [ADD] [16.0] sale_order_line_product_attribute_values #3432 MT-6867 (00:50 min)) - Watch Video
|
Shide
force-pushed
the
16.0-sale_order_line_product-attribute_values
branch
from
5bbbc37 to
6c91fb7
Compare
|
Added context checking on the function to avoid recompute on initial installation. Also added CONFIGURE.md to show how to recompute lines. |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 7723498. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store all product attribute values used directly or indirectly on the sale.order.line
You can view this attributes installing sale_order_line_menu module.
MT-6867 @moduon @rafaelbn @fcvalgar @Gelojr please review if you want