[15.0] Forward-port of [FIX] sale_order_line_chained_move: Fix infinite recursion #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__find_origin_moves` function doesn't take into account loops in
the chains of origin moves. Fix this by adding a "visited" record set
which will make sure that any move that has already be expanded won't be
processed again.
This will allow updating the modules (`odoo-bin -u all`) even when there
is existing data which has cycles in their origin graph. The error for
that case looked like this:
INFO odoo odoo.modules.loading: Loading module sale_order_line_chained_move (185/225)
...
File ".../thirdparty/odoo/addons/sale_order_line_chained_move/hooks.py", line 10, in __find_origin_moves
all_moves |= __find_origin_moves(move.move_orig_ids)
[Previous line repeated 978 more times]
File ".../thirdparty/odoo/addons/sale_order_line_chained_move/hooks.py", line 9, in __find_origin_moves
if move.move_orig_ids:
...
RecursionError: maximum recursion depth exceeded
|
Hi @rousseldenis, |
marielejeune
changed the title
marielejeune
changed the title
rousseldenis
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of the original fix in v13. See PRs #2638 (v13) and #2650 (v14).