Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] base_tier_validation: Add reminder option #931

Closed
wants to merge 1 commit into from
Closed

[17.0][IMP] base_tier_validation: Add reminder option #931

wants to merge 1 commit into from

Conversation

TDu
Copy link
Member

@TDu TDu commented Jul 26, 2024

Forward port from #873

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@LoisRForgeFlow
Copy link
Contributor

Thanks @TDu

The test are failing, and it is one of the new ones about the reminders, could you have a look?

@LoisRForgeFlow
Copy link
Contributor

Hi @TDu

Just a reminder for this reminder thing here 😆

It would be good to get this merged to align versions.

Thanks!!

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Oct 31, 2024
Merged
@LoisRForgeFlow
Copy link
Contributor

This patch it is likely also needed here #960

@TDu TDu force-pushed the 17-imp-validation-with-reminder branch from 6fc7769 to 8fde4a0 Compare November 20, 2024 14:57
@TDu
Copy link
Member Author

TDu commented Nov 20, 2024

This patch it is likely also needed here #960

I think you meant #968 and it has been included

@TDu
Copy link
Member Author

TDu commented Nov 22, 2024

Closing, it will be ported in #968 where the test issue if fixed

@TDu TDu closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TDu @OCA-git-bot @LoisRForgeFlow