Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_barcodes_picking_batch: Migration to v15.0 #533

Merged
merged 5 commits into from
Oct 28, 2023

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Oct 6, 2023

cc @Tecnativa TT45429

Standard migration to v15.

dependens on:

supersed #523

ping @carlosdauden @CarlosRoca13 @Tisho99

@sergio-teruel sergio-teruel marked this pull request as draft October 6, 2023 17:04
@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_barcodes_picking_batch branch 5 times, most recently from 1575edf to bfffa5b Compare October 13, 2023 13:19
@sergio-teruel sergio-teruel marked this pull request as ready for review October 13, 2023 13:35
@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_barcodes_picking_batch branch from b2c6605 to 8e7f580 Compare October 25, 2023 19:04
@pedrobaeza
Copy link
Member

Please remove latest commit.

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_barcodes_picking_batch branch from 3a7d780 to ba25209 Compare October 26, 2023 07:37
@sergio-teruel
Copy link
Contributor Author

Rebased and removed the latest commit

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Minor change


@tagged("post_install", "-at_install")
class TestStockBarcodesPickingBatch(TestStockBarcodesPicking):
def setUp(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer classmethod instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upps!!! +1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please include the context keys for speeding up tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_barcodes_picking_batch branch from ba25209 to 99a9124 Compare October 26, 2023 09:15
@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_barcodes_picking_batch branch from 99a9124 to a84140e Compare October 27, 2023 06:09
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-533-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b42554a into OCA:15.0 Oct 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b08c3b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-stock_barcodes_picking_batch branch October 30, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants