-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] stock_barcodes_picking_batch: Migration to v15.0 #533
[15.0][MIG] stock_barcodes_picking_batch: Migration to v15.0 #533
Conversation
1575edf
to
bfffa5b
Compare
b2c6605
to
8e7f580
Compare
Please remove latest commit. |
3a7d780
to
ba25209
Compare
Rebased and removed the latest commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Minor change
|
||
@tagged("post_install", "-at_install") | ||
class TestStockBarcodesPickingBatch(TestStockBarcodesPicking): | ||
def setUp(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer classmethod instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upps!!! +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please include the context keys for speeding up tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
ba25209
to
99a9124
Compare
99a9124
to
a84140e
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 5b08c3b. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT45429
Standard migration to v15.
dependens on:
supersed #523
ping @carlosdauden @CarlosRoca13 @Tisho99